Skip to content

Commit 203a391

Browse files
committed
Merge tag 'ctsm5.4.011' into CUPiD
Merge b4b-dev to master - Change some _U and _R history fields to be on by default PR #3667 by Keith Oleson - Update to cime version that fixes the check_input_data --download issue PR #3647 by Erik Kluzek; #3647 updated to cime6.1.145, while updating b4b-dev to master in this PR gets us to cime6.1.146. - Initial fixes to generate_gdd20_baseline PR #3543 - Decomp mod unittest PR #3699
2 parents 76bb364 + 2f7aac6 commit 203a391

24 files changed

+622
-64
lines changed

.gitmodules

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ fxDONOTUSEurl = https://github.com/ESMCI/ccs_config_cesm.git
7676
[submodule "cime"]
7777
path = cime
7878
url = https://github.com/ESMCI/cime
79-
fxtag = cime6.1.144
79+
fxtag = cime6.1.146
8080
fxrequired = ToplevelRequired
8181
# Standard Fork to compare to with "git fleximod test" to ensure personal forks aren't committed
8282
fxDONOTUSEurl = https://github.com/ESMCI/cime

doc/.ChangeLog_template

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,8 @@ Changes answers relative to baseline:
148148

149149
If this tag changes climate list the run(s) done to evaluate the new
150150
climate (from https://github.com/NCAR/LMWG_dev)
151-
- issue number:
151+
- issue number(s):
152152

153-
URL for LDF diagnostics output used to validate new climate:
154-
-
155153
Other details
156154
-------------
157155
[Remove any lines that don't apply. Remove entire section if nothing applies.]

doc/ChangeLog

Lines changed: 250 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,254 @@
11
===============================================================
2+
Tag name: ctsm5.4.011
3+
Originator(s): slevis (Samuel Levis,UCAR/TSS,303-665-1310)
4+
Date: Thu Jan 22 04:01:52 PM MST 2026
5+
One-line Summary: Merge b4b-dev to master
6+
7+
Purpose and description of changes
8+
----------------------------------
9+
Change some _U and _R history fields to be on by default PR #3667 by Keith Oleson
10+
Update to cime version that fixes the check_input_data --download issue PR #3647 by Erik Kluzek; #3647 updated to cime6.1.145, while updating b4b-dev to master in this PR gets us to cime6.1.146.
11+
Initial fixes to generate_gdd20_baseline PR #3543
12+
Decomp mod unittest PR #3699
13+
14+
Significant changes to scientifically-supported configurations
15+
--------------------------------------------------------------
16+
17+
Does this tag change answers significantly for any of the following physics configurations?
18+
(Details of any changes will be given in the "Answer changes" section below.)
19+
20+
[Put an [X] in the box for any configuration with significant answer changes.]
21+
22+
[ ] clm6_0
23+
24+
[ ] clm5_0
25+
26+
[ ] ctsm5_0-nwp
27+
28+
[ ] clm4_5
29+
30+
31+
Bugs fixed
32+
----------
33+
List of CTSM issues fixed (include CTSM Issue # and description) [one per line]:
34+
No issues were opened for the PRs listed above.
35+
36+
Testing summary:
37+
----------------
38+
39+
[PASS means all tests PASS; OK means tests PASS other than expected fails.]
40+
41+
build-namelist tests (if CLMBuildNamelist.pm has changed):
42+
43+
derecho - OK
44+
45+
python testing (if python code has changed; see instructions in python/README.md; document testing done):
46+
47+
derecho - OK
48+
49+
regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):
50+
51+
derecho ----- OK
52+
izumi ------- OK
53+
54+
Answer changes
55+
--------------
56+
Changes answers relative to baseline: No
57+
58+
Other details
59+
-------------
60+
Pull Requests that document the changes (include PR ids):
61+
https://github.com/ESCOMP/ctsm/pull/3709
62+
63+
===============================================================
64+
===============================================================
65+
Tag name: ctsm5.4.010
66+
Originator(s): erik (Erik Kluzek,UCAR/TSS,303-497-1326)
67+
Date: Wed Jan 21 11:49:59 AM MST 2026
68+
One-line Summary: Update cime to version that changes answers for ERI tests
69+
70+
Purpose and description of changes
71+
----------------------------------
72+
73+
This just updates the cime version to one that changes answers for ERI tests.
74+
75+
76+
Significant changes to scientifically-supported configurations
77+
--------------------------------------------------------------
78+
79+
Does this tag change answers significantly for any of the following physics configurations?
80+
(Details of any changes will be given in the "Answer changes" section below.)
81+
82+
[Put an [X] in the box for any configuration with significant answer changes.]
83+
84+
[ ] clm6_0
85+
86+
[ ] clm5_0
87+
88+
[ ] ctsm5_0-nwp
89+
90+
[ ] clm4_5
91+
92+
93+
Bugs fixed
94+
----------
95+
96+
List of CTSM issues fixed (include CTSM Issue # and description) [one per line]:
97+
Fixes #3651 -- update to cime6.1.146 changes answers
98+
99+
Notes of particular relevance for users
100+
---------------------------------------
101+
102+
Notes of particular relevance for developers:
103+
---------------------------------------------
104+
105+
Changes to tests or testing:
106+
107+
The details of the ERI tests was changed, so that you can't compare to the previous baselines.
108+
This means that it registers them as all failing the baseline compare with a DIFF
109+
110+
Testing summary: regular
111+
----------------
112+
[PASS means all tests PASS; OK means tests PASS other than expected fails.]
113+
114+
regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):
115+
116+
derecho ----- OK
117+
izumi ------- OK
118+
119+
If the tag used for baseline comparisons was NOT the previous tag, note that here:
120+
121+
122+
Answer changes
123+
--------------
124+
125+
Changes answers relative to baseline: No (other than the ERI tests!)
126+
127+
Summarize any changes to answers, i.e.,
128+
- what code configurations: Only ERI tests
129+
- what platforms/compilers: All
130+
- nature of change: test details changed so can't be compared to the baseline
131+
132+
Other details
133+
-------------
134+
[Remove any lines that don't apply. Remove entire section if nothing applies.]
135+
136+
List any git submodules updated (cime, rtm, mosart, cism, fates, etc.): cime
137+
Update to cime6.1.146
138+
139+
Pull Requests that document the changes (include PR ids):
140+
(https://github.com/ESCOMP/ctsm/pull)
141+
142+
https://github.com/ESCOMP/CTSM/pull/3698
143+
144+
===============================================================
145+
===============================================================
146+
Tag name: ctsm5.4.009
147+
Originator(s): olyson (Keith Oleson)
148+
Date: Mon Jan 19 12:53:18 PM MST 2026
149+
One-line Summary: Dewpoint Temperature check for bare ground
150+
151+
Purpose and description of changes
152+
----------------------------------
153+
154+
Implement dewpoint temperature check for bare ground to fix RRTMG error
155+
156+
Cecile Hannay reported an RRTMGP crash in this 4xCO2 experiment at year 37:
157+
158+
NCAR/cesm_dev#246
159+
160+
Output from placing write statements in the CAM radiation code show that it's a baresoil patch in
161+
a grid cell in the Arabian Penninsula. The bare soil patch occupies 99.28% of the gridcell.
162+
Solar and longwave forcing and absorbed solar don't appear to be unreasonable, but t_grnd is 358K.
163+
164+
This bug fix eliminates dew flux (sets evaporation conductance to zero) x if t_grnd > forc_dewpoint, where forc_dewpoint is the dewpoint temperature at the forcing height.
165+
This prevents large spurious negative latent heat fluxes that increase heat flux into the soil and signficantly increase surface soil temperature (t_grnd) such that soil temperature > 355K, triggering a RRTMGP error.
166+
167+
Contributors:
168+
-------------
169+
@swensosc , @wwieder , @slevis-lmwg , @dlawrenncar, ekluzek
170+
171+
172+
Significant changes to scientifically-supported configurations
173+
--------------------------------------------------------------
174+
175+
Does this tag change answers significantly for any of the following physics configurations?
176+
(Details of any changes will be given in the "Answer changes" section below.)
177+
178+
[Put an [X] in the box for any configuration with significant answer changes.]
179+
180+
[ ] clm6_0
181+
182+
[ ] clm5_0
183+
184+
[ ] ctsm5_0-nwp
185+
186+
[ ] clm4_5
187+
188+
189+
Bugs fixed
190+
----------
191+
192+
List of CTSM issues fixed (include CTSM Issue # and description) [one per line]:
193+
Fixes #3589 355+ K land temperature triggers RRTMGP error
194+
195+
Notes of particular relevance for users
196+
---------------------------------------
197+
198+
Caveats for users (e.g., need to interpolate initial conditions):
199+
This is currently ONLY done for bare-soil, probably should be done for other landunits.
200+
201+
Changes to documentation: None, but needs to be added
202+
203+
Notes of particular relevance for developers:
204+
---------------------------------------------
205+
206+
Caveats for developers (e.g., code that is duplicated that requires double maintenance):
207+
https://github.com/ESCOMP/CTSM/issues/3694
208+
Documents making this a function added to QSat
209+
This should especially be done when this is added for other landunit types
210+
211+
Testing summary: regular
212+
----------------
213+
[PASS means all tests PASS; OK means tests PASS other than expected fails.]
214+
215+
regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):
216+
217+
derecho ----- OK
218+
izumi ------- OK
219+
220+
If the tag used for baseline comparisons was NOT the previous tag, note that here:
221+
222+
223+
Answer changes
224+
--------------
225+
226+
Changes answers relative to baseline: Yes! Almost ALL cases if run long enough
227+
228+
Summarize any changes to answers, i.e.,
229+
- what code configurations: All
230+
- what platforms/compilers: All
231+
- nature of change: same climate
232+
233+
climate (from https://github.com/NCAR/LMWG_dev)
234+
- issue number(s): 135 and 136
235+
236+
URL for LDF diagnostics output used to validate new climate:
237+
238+
- ILAMB: https://webext.cgd.ucar.edu/I2000/Clm60SP_ctsmdew_1deg_Dew_2000/lnd/BUGFIX/_build_DEW/
239+
- LDF: https://webext.cgd.ucar.edu/I2000/Clm60SP_ctsmdew_1deg_Dew_2000/lnd/BUGFIX/Clm60SP_ctsmdew_1deg_Dew_2000_2005_2019-Clm60SP_ctsmdew_1deg_Control_2000_2005_2019/setsIndex.html
240+
241+
Standard diagnostics results are here
242+
Other details
243+
-------------
244+
245+
Pull Requests that document the changes (include PR ids):
246+
(https://github.com/ESCOMP/ctsm/pull)
247+
#3688 -- Implement dewpoint temperature check for bare ground to fix RRTMGP error
248+
249+
250+
===============================================================
251+
===============================================================
2252
Tag name: ctsm5.4.008
3253
Originator(s): swensosc (Sean Swenson)
4254
Date: Mon Jan 12 11:19:38 PM MST 2026

doc/ChangeSum

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
Tag Who Date Summary
22
============================================================================================================================
3+
ctsm5.4.011 slevis 01/22/2026 Merge b4b-dev to master
4+
ctsm5.4.010 erik 01/21/2026 Update cime to version that changes answers for ERI tests
5+
ctsm5.4.009 olyson 01/19/2026 Dewpoint Temperature check for bare ground
36
ctsm5.4.008 swensosc 01/12/2026 Add a correction for oversaturated soil layers in SoilWaterMovement (erik)
47
ctsm5.4.007 samrabin 01/09/2026 Update (irrigated_)rice grnfill and lfemerg
58
ctsm5.4.006 erik 01/07/2026 Merge b4b-dev to master

python/ctsm/crop_calendars/check_rx_obeyed.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ def check_rx_obeyed(
144144
continue
145145
ds_thisveg = dates_ds.isel(patch=thisveg_patches)
146146

147-
vegtype_int = utils.vegtype_str2int(vegtype_str)[0]
147+
vegtype_int = utils.vegtype_str2int(vegtype_str)
148148
rx_da = rx_ds[f"gs1_{vegtype_int}"]
149149
rx_array = rx_da.values[
150150
ds_thisveg.patches1d_jxy.values.astype(int) - 1,

python/ctsm/crop_calendars/cropcal_utils.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -265,6 +265,8 @@ def vegtype_str2int(vegtype_str, vegtype_mainlist=None):
265265
convert_to_ndarray = not isinstance(vegtype_str, np.ndarray)
266266
if convert_to_ndarray:
267267
vegtype_str = np.array(vegtype_str)
268+
was_0d = vegtype_str.ndim == 0
269+
vegtype_str = np.atleast_1d(vegtype_str)
268270

269271
if isinstance(vegtype_mainlist, xr.Dataset):
270272
vegtype_mainlist = vegtype_mainlist.vegtype_str.values
@@ -289,6 +291,10 @@ def vegtype_str2int(vegtype_str, vegtype_mainlist=None):
289291
indices[np.where(vegtype_str == vegtype_str_2)] = vegtype_mainlist.index(vegtype_str_2)
290292
if convert_to_ndarray:
291293
indices = [int(x) for x in indices]
294+
295+
if was_0d:
296+
indices = indices[0]
297+
292298
return indices
293299

294300

0 commit comments

Comments
 (0)