CAM LndTuningMode testmods should only shorten ROF_NCPL for short tests

[ekluzek]

Brief summary of bug

ROF_NCPL, for at least the clm60cam7LndTuningMode (and likely for the others as well), is higher frequency which is needed for the 9-step cases, but longer cases don't need that done. So tests should only do this for the short 9 step cases and NOT for cases longer than 3 hours.

General bug information

CTSM version you are using: ctsm5.4.022-6-gf2b311cc9

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: tests using one of the LndTuningMode testmods

Details of bug

One implementation would be to have the shell_commands check the value of STOP_OPTION and only change ROF_NCPL if it's set to nsteps. This would probably be fine, since it's only a few tests currently the only nstep tests are either for 9 or 1 step (numbers of tests are 49 and 11 respectively).

Important details of your setup / configuration so we can reproduce the bug

I saw this in a SMS.ne30pg3_t232.I2000Clm60BgcCrop.derecho_intel.clm-clm60cam7LndTuningMode test.

Important output or errors that show the problem

git grep NCPL | more
FatesColdCamLndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
FatesColdSatPhenCamLndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm45cam4LndTuningModeZDustSoilErod/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm50cam5LndTuningModeZDustSoilErod/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm50cam6LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm50cam7LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm60cam6LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
clm60cam7LndTuningMode/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
for_testing_fastsetup_bypassrun/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'
waccmx_offline/shell_commands:./xmlchange USE_ESMF_LIB=TRUE,ATM_NCPL=288,CALENDAR=GREGORIAN,ROF_NCPL='$ATM_NCPL',LND_TUNING_MODE="clm5_0_cam6.0"
waccmx_offline/shell_commands:./xmlchange ROF_NCPL='$ATM_NCPL'

And this applies to all of these tests (from git grep LndTuning testlist_clm.xml | grep -v Ln9):

testlist_clm.xml:  <test name="ERP_D_Ld9" grid="ne30pg3_t232" compset="I1850Clm60BgcCropG" testmods="clm/clm60cam7LndTuningModeLDust">
testlist_clm.xml:    <test name="ERP_D_Ld9" grid="f10_f10_mg37" compset="I1850Clm60BgcCrop" testmods="clm/clm60cam7LndTuningModeLDust">
testlist_clm.xml:  <test name="ERP_D_Ld9" grid="f10_f10_mt232" compset="IHistClm60BgcCrop" testmods="clm/clm60cam7LndTuningModeLDust--clm/nnStreamMapAlgo">
testlist_clm.xml:  <test name="ERP_D_Ld9" grid="ne30pg3_t232" compset="I1850Clm60BgcCropG" testmods="clm/clm60cam6LndTuningMode">
testlist_clm.xml:  <test name="ERP_D_Ld9" grid="ne30pg3_t232" compset="IHistClm60BgcCropG" testmods="clm/clm60cam7LndTuningModeLDust">
testlist_clm.xml:  <test name="ERS_D_Ld9" grid="ne30pg3_t232" compset="I1850Clm60BgcCropG" testmods="clm/clm60cam7LndTuningMode">
testlist_clm.xml:  <test name="ERI_D" grid="ne30pg3_t232" compset="I1850Clm60BgcCropG" testmods="clm/clm60cam7LndTuningModeLDust">
testlist_clm.xml:  <test name="SMS_Lm1" grid="ne30pg3_t232" compset="I1850Clm60BgcCropG" testmods="clm/clm60cam7LndTuningMode">
testlist_clm.xml:  <test name="SMS_Lm1" grid="ne30pg3_t232" compset="I1850Clm60BgcCropCrujraG" testmods="clm/clm60cam7LndTuningMode">
testlist_clm.xml:  <test name="SMS" grid="ne30pg3_t232" compset="I2000Clm60BgcCrop" testmods="clm/clm60cam7LndTuningMode">
testlist_clm.xml:  <test name="SMS_Ld1" grid="f09_g17" compset="I1850Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS_Ld1" grid="f09_t232" compset="I1850Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS_Ld1" grid="f19_g17" compset="I1850Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS_Ld1" grid="f19_g17" compset="I1850Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne3pg3_ne3pg3_mg37" compset="IHistClm60SpRs" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne3pg3_ne3pg3_mg37" compset="IHistClm60SpCrujraRs" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne3pg3_ne3pg3_mg37" compset="I2000Clm60SpRs" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne3pg3_ne3pg3_mg37" compset="I2000Clm60SpCrujraRs" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne3pg2_ne3pg2_mt232" compset="I2000Clm60SpCrujraRs" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne3pg2_ne3pg2_mt232" compset="IHistClm60SpCrujraRs" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne16pg3_ne16pg3_mg17" compset="I1850Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne16pg3_ne16pg3_mg17" compset="I1850Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne16pg3_ne16pg3_mg17" compset="I2000Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne16pg3_ne16pg3_mg17" compset="I2000Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne16pg3_ne16pg3_mg17" compset="IHistClm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne16pg3_ne16pg3_mg17" compset="IHistClm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30_g17" compset="I2000Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30_g17" compset="I2000Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30pg2_ne30pg2_mg17" compset="I1850Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30pg2_ne30pg2_mg17" compset="I1850Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30pg2_ne30pg2_mg17" compset="I2000Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30pg2_ne30pg2_mg17" compset="I2000Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:   <test name="SMS" grid="ne30pg3_ne30pg3_mg17" compset="IHistClm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:   <test name="SMS" grid="ne30pg3_ne30pg3_mg17" compset="IHistClm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30pg3_ne30pg3_mg17" compset="I2000Clm60Sp" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS" grid="ne30pg3_ne30pg3_mg17" compset="I2000Clm60SpCrujra" testmods="clm/clm60cam7LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="SMS_D_Ld1_PS" grid="f19_f19_mg17" compset="I2010Clm50Sp" testmods="clm/clm50cam6LndTuningMode--clm/nofireemis">
testlist_clm.xml:  <test name="ERI_D_Ld9" grid="f45_f45_mg37" compset="I2000Clm60FatesSpCruRsGs" testmods="clm/FatesColdSatPhenCamLndTuningMode">
testlist_clm.xml:  <test name="ERS_D_Ld5" grid="f45_f45_mg37" compset="I2000Clm60Fates" testmods="clm/FatesColdCamLndTuningMode">
testlist_clm.xml:  <test name="ERI_D_Ld9" grid="f45_f45_mg37" compset="I2000Clm60Fates" testmods="clm/FatesColdCamLndTuningMode">

The for_testing_fastsetup_bypassrun and waccmx_offline tests are both short on purpose, so it's OK for it to be short.