Merge pull request #138 from nathanlcarlson/commit_removal

Commit removal

Author: sashakames

src/java/main/esg/search/publish/impl/solr/SolrClient.java

@@ -67,7 +67,7 @@ public SolrClient(final URL url) {
      * Method to index a single XML record.
      * @param xml.
      * @param type : chosen among the supported record types.
-     * @param commit : true to commit the transaction after indexing this record, false if other records are coming.
+     * @param commit : This parameter has no effect
      * @return
      * @throws Exception
      */
@@ -83,7 +83,11 @@ public String index(final String xml, final String type, boolean commit) throws
         String response = httpClient.doPost(postUrl, xml, true);
 
         // commit changes, do not optimize for a single record
-        if (commit) this.commit();
+        // This results in a high frequency of commits
+        // Which puts non-negligable load on Solr instances
+        // Future work would be to make this externally configurable
+        // For now, Solr "autoCommit" features will be used to perform commits
+        // if (commit) this.commit();
 
         return response;
 
@@ -133,7 +137,8 @@ public String delete(List<String> ids, Collection<String> cores) throws Exceptio
         }
 
         // commit changes to all cores
-        commit();
+        // Solr "autoCommit" features will be used to perform commits
+        // commit();
 
         return sb.toString();
 

src/java/main/esg/search/publish/impl/solr/SolrIndexer.java

@@ -93,7 +93,8 @@ public void consume(final Collection<Record> records) throws Exception {
         }
 
         // commit all records at once, to all cores
-        solrClient.commit();
+        // Solr "autoCommit" features will be used to perform commits
+        // solrClient.commit();
 
     }