Skip to content

Generalized mask: use any given dataset cube to construct a mask to be applied to all other dataset cubes #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Generalized mask: use any given dataset cube to construct a mask to be applied to all other dataset cubes #1803

wants to merge 6 commits into from

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Nov 17, 2022 •
edited
Loading

Description

Closes #1804

Link to documentation: to be added

Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

To help with the number pull requests:

@valeriupredoi valeriupredoi added enhancement New feature or request preprocessor Related to the preprocessor labels Nov 17, 2022
@valeriupredoi valeriupredoi changed the title Generalized mask: use any given dataset cube to construct a mask to be applied to all dataset cubes Generalized mask: use any given dataset cube to construct a mask to be applied to all other dataset cubes Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022 •
edited
Loading

Codecov Report

❌ Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.73%. Comparing base (989839f) to head (739cd61).
⚠️ Report is 360 commits behind head on main.

Files with missing lines Patch % Lines
esmvalcore/preprocessor/_mask.py 81.81% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (81.81%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1803      +/-   ##
==========================================
- Coverage   93.74%   93.73%   -0.01%     
==========================================
  Files         238      238              
  Lines       13153    13164      +11     
==========================================
+ Hits        12330    12339       +9     
- Misses        823      825       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valeriupredoi valeriupredoi mentioned this pull request Nov 17, 2022
Open
@valeriupredoi valeriupredoi added this to the v2.12.0 milestone Apr 25, 2024
@sloosvel
Copy link
Contributor

sloosvel commented Feb 4, 2025

Hi @valeriupredoi ,

The code freeze for version 2.12 is scheduled for next week on Feb 11th. Do you think you will have time to finish the PR for this release? If not, let me know and I will move it to the next milestone.

@valeriupredoi valeriupredoi modified the milestones: v2.12.0, v2.13.0 Feb 7, 2025
@malininae
Copy link
Contributor

malininae commented Mar 5, 2025 •
edited
Loading

I think it would be a great preprocessor! Do you need assistance on it?

@jlenh jlenh modified the milestones: v2.13.0, v2.14.0 Aug 21, 2025
@bouweandela bouweandela removed this from the v2.14.0 milestone Oct 3, 2025
@valeriupredoi
Copy link
Contributor Author

I think it would be a great preprocessor! Do you need assistance on it?

thanks @malininae 🍺 Might have to revive this dead horse after all, will ping you 🐴 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request preprocessor Related to the preprocessor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Generalized mask: apply a mask built from a dataset to all other datasets

5 participants

@valeriupredoi @sloosvel @malininae @bouweandela @jlenh