replace nbsphinx with myst-nb #4200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merge this, then #4182 will be good to merge too 🍻 |
jlenh
approved these changes
Sep 15, 2025
There was a problem hiding this comment.
Should the pin on ipython be removed as in ESMValGroup/ESMValCore#2838?
(Definitely not an expert on all of these dependencies but that's the only thing I could see here 🤓)
ah good catch! I didn't even check, was under the assumption we were picking it up from core, done in a2358d2 cheers, Julien 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sister PR to Core's ESMValGroup/ESMValCore#2838
Frankly I don't really understand why we even listed
nbsphinxas a dependencyhere, if we are not using it as an extension in doc building, we should just grab it fromesmvalcore's dependencies.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.