Merge pull request #45 from ESP32Async/fix/error-500

mathieucarbou · web-flow · commit 673431eac2fd · 2025-02-01T18:59:32.000+01:00
fix(http): Status 404 should be returned by default when no notFoundHandler is set. This is not an internal server error.
diff --git a/src/WebHandlers.cpp b/src/WebHandlers.cpp
@@ -299,7 +299,7 @@ void AsyncCallbackWebHandler::handleRequest(AsyncWebServerRequest *request) {
   if (_onRequest) {
     _onRequest(request);
   } else {
-    request->send(500);
+    request->send(404, T_text_plain, "Not found");
   }
 }
 void AsyncCallbackWebHandler::handleUpload(AsyncWebServerRequest *request, const String &filename, size_t index, uint8_t *data, size_t len, bool final) {

Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ void AsyncCallbackWebHandler::handleRequest(AsyncWebServerRequest *request) {`
`299`	`299`	`if (_onRequest) {`
`300`	`300`	`_onRequest(request);`
`301`	`301`	`} else {`
`302`		`- request->send(500);`
	`302`	`+ request->send(404, T_text_plain, "Not found");`
`303`	`303`	`}`
`304`	`304`	`}`
`305`	`305`	`void AsyncCallbackWebHandler::handleUpload(AsyncWebServerRequest request, const String &filename, size_t index, uint8_t data, size_t len, bool final) {`