Fix some clang warnings.

Most of these are related to Initialize list ordering.
None of them should have any runtime impact.

Author: hef

OSCWidgets/EditPanel.cpp

@@ -28,8 +28,8 @@
 EditButton::EditButton(QWidget *parent)
 	: QPushButton(parent)
 	, m_Selected(false)
-	, m_T(PI_PLUS_PI_2)
 	, m_Alpha(0)
+	, m_T(PI_PLUS_PI_2)
 {
 	m_Timer = new QTimer(this);
 	connect(m_Timer, SIGNAL(timeout()), this, SLOT(onTick()));

OSCWidgets/NetworkThreads.cpp

@@ -327,9 +327,9 @@ void EosUdpInThread::OSCParserClient_Log(const std::string &message)
 
 EosTcpClientThread::EosTcpClientThread()
 	: m_Port(0)
-	, m_LogMsgType(EosLog::LOG_MSG_TYPE_INFO)
 	, m_Run(false)
 	, m_Mutex(QMutex::Recursive)
+	, m_LogMsgType(EosLog::LOG_MSG_TYPE_INFO)
 {
 }
 

OSCWidgets/SettingsPanel.cpp

@@ -25,8 +25,8 @@
 ////////////////////////////////////////////////////////////////////////////////
 
 AddToyButton::AddToyButton(int type, QWidget *parent)
-	: m_Type(type)
-	, QPushButton(parent)
+	: QPushButton(parent)
+	, m_Type(type)
 {
 	QString label;
 	Toy::GetName(static_cast<Toy::EnumToyType>(m_Type), label);

OSCWidgets/Toy.cpp

@@ -96,7 +96,7 @@ Toy* Toy::Create(EnumToyType type, Client *pClient, QWidget *parent, Qt::WindowF
 		case TOY_WINDOW:		return (new ToyWindow(pClient,parent,flags));
 	}
 
-	return 0;
+	return nullptr;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -148,7 +148,7 @@ void Toy::GetDefaultPathName(EnumToyType type, QString &name)
 void Toy::SetDefaultWindowIcon(QWidget &w)
 {
 	// NOTE: looks cleaner without window icons on Mac
-
+	Q_UNUSED(w);
 #ifdef WIN32
 	static QIcon *sIcon = 0;
 	if( !sIcon )

OSCWidgets/ToyGrid.cpp

@@ -132,7 +132,7 @@ void GridSizeMenu::onHovered(int col, int row)
 void GridSizeMenu::onClicked(int col, int row)
 {
 	emit gridResized(m_Id, QSize(col+1,row+1));
-	emit triggered(0);
+	emit triggered(nullptr);
 }
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -141,11 +141,11 @@ ToyGrid::ToyGrid(EnumToyType type, Client *pClient, QWidget *parent, Qt::WindowF
 	: Toy(type, pClient, parent, flags)
 	, m_Mode(ToyWidget::MODE_DEFAULT)
 	, m_GridSize(0, 0)
-	, m_SendOnConnect(false)
+	, m_EditPanel(nullptr)
 	, m_IgnoreEdits(0)
-	, m_pContextMenu(0)
+	, m_SendOnConnect(false)
+	, m_pContextMenu(nullptr)
 	, m_Loading(false)
-	, m_EditPanel(0)
 {
 	QString name;
 	Toy::GetName(m_Type, name);

OSCWidgets/ToySlider.cpp

@@ -26,10 +26,10 @@
 
 FadeSlider::FadeSlider(QWidget *parent)
 	: FadeButton(parent)
-	, m_TextMargin(0)
-	, m_LabelMargin(0)
 	, m_Percent(0)
 	, m_MouseDown(false)
+	, m_TextMargin(0)
+	, m_LabelMargin(0)
 {
 	m_RecvPercent.pending = false;
 	m_RecvPercent.percent = 0;

OSCWidgets/ToyWidget.cpp

@@ -27,9 +27,9 @@
 
 ToyWidget::ToyWidget(QWidget *parent)
 	: QWidget(parent)
-	, m_Widget(0)
 	, m_Mode(MODE_DEFAULT)
 	, m_Visible(true)
+	, m_Widget(nullptr)
 	, m_Min("0")
 	, m_Max("1")
 	, m_Min2("0")

OSCWidgets/ToyXY.cpp

@@ -26,10 +26,10 @@
 
 FadeXY::FadeXY(QWidget *parent)
 	: FadeButton(parent)
-	, m_TextMargin(0)
-	, m_LabelMargin(0)
 	, m_Pos(0.5, 0.5)
 	, m_MouseDown(false)
+	, m_TextMargin(0)
+	, m_LabelMargin(0)
 {
 	m_RecvPos.pending = false;
 	m_RecvPos.pos = QPointF(0, 0);

OSCWidgets/Utils.cpp

@@ -341,6 +341,7 @@ LRESULT CALLBACK EosMouseMsgProc(int nCode, WPARAM wParam, LPARAM lParam)
 
 void Utils::BlockFakeMouseEvents(bool b)
 {
+	Q_UNUSED(b);
 #ifdef WIN32
 	if( b )
 	{