Remove unused charger Mutex descriptions for pause and resume. Pause and resume charging is only accepted when a transaction is active

Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>

Author: Pietfried

modules/EVSE/EvseManager/Charger.cpp

@@ -774,7 +774,6 @@ void Charger::run_state_machine() {
 
             if (not shared_context.flag_transaction_active or not shared_context.flag_authorized or
                 not shared_context.flag_ev_plugged_in) {
-                EVLOG_warning << "going to stop from pause 1";
                 set_state(EvseState::StoppingCharging);
                 break;
             }
@@ -805,11 +804,11 @@ void Charger::run_state_machine() {
                 // be shut down before SessionStop.req)
 
                 if (shared_context.hlc_charging_terminate_pause == HlcTerminatePause::Terminate) {
-                    // EV wants to terminate session. We still stay in PausedEV since it could restart a session as long as it is not unplugged.
+                    // EV wants to terminate session. We still stay in PausedEV since it could restart a session as long
+                    // as it is not unplugged.
                     if (shared_context.pwm_running) {
                         pwm_off();
                     }
-
                 } else if (shared_context.hlc_charging_terminate_pause == HlcTerminatePause::Pause) {
                     // EV wants an actual pause
                     if (shared_context.pwm_running) {
@@ -966,8 +965,6 @@ void Charger::run_state_machine() {
                 bsp->allow_power_on(false, types::evse_board_support::Reason::PowerOff);
             }
 
-            // FIXME: wait here for SLAC to become available again
-
             // If unplugged, stop session and proceed to Idle, otherwise wait here and do nothing
             if (not shared_context.flag_ev_plugged_in) {
                 stop_session();
@@ -1238,14 +1235,19 @@ bool Charger::set_max_current(float c, std::chrono::time_point<std::chrono::stea
 
 // set pausing flag, it will be picked up by the state machine.
 bool Charger::pause_charging() {
-    shared_context.flag_paused_by_evse = true;
-    // FIXME: this now always works. Does this cause problems?
-    return true;
+    if (shared_context.flag_transaction_active) {
+        shared_context.flag_paused_by_evse = true;
+        return true;
+    }
+    return false;
 }
 
 bool Charger::resume_charging() {
-    shared_context.flag_paused_by_evse = false;
-    // FIXME: this now always works. Does this cause problems?
+    if (shared_context.flag_transaction_active) {
+        shared_context.flag_paused_by_evse = false;
+        return true;
+    }
+    return false;
     return true;
 }
 

modules/EVSE/EvseManager/Charger.hpp

@@ -346,7 +346,8 @@ class Charger {
         int sleep_before_enabling_pwm_hlc_mode_ms{1000};
         // type used to generate session ids
         utils::SessionIdType session_id_type{utils::SessionIdType::UUID};
-        // Timeout in seconds that defines for how long the EVSE allows the ISO charge loop (AC: ChargingStatus, DC: CurrentDemand)
+        // Timeout in seconds that defines for how long the EVSE allows the ISO charge loop (AC: ChargingStatus, DC:
+        // CurrentDemand)
         int hlc_charge_loop_without_energy_timeout_s{300};
     } config_context;
 

modules/EVSE/EvseManager/scoped_lock_timeout.hpp

@@ -22,8 +22,6 @@ enum class MutexDescription {
     Charger_signal_error_cleared,
     Charger_mainloop,
     Charger_process_event,
-    Charger_pause_charging,
-    Charger_resume_charging,
     Charger_waiting_for_power,
     Charger_resume_power_available,
     Charger_cancel_transaction,
@@ -103,10 +101,6 @@ static std::string to_string(MutexDescription d) {
         return "Charger.cpp: mainloop";
     case MutexDescription::Charger_process_event:
         return "Charger.cpp: process_event";
-    case MutexDescription::Charger_pause_charging:
-        return "Charger.cpp: pause_charging";
-    case MutexDescription::Charger_resume_charging:
-        return "Charger.cpp: resume_charging";
     case MutexDescription::Charger_waiting_for_power:
         return "Charger.cpp: pause_charging_wait_for_power";
     case MutexDescription::Charger_cancel_transaction: