fix(orchestration): error where we ensure there are new leaves even for functions where there are no new commitments

Author: lydiagarms

src/boilerplate/orchestration/javascript/raw/toOrchestration.ts

@@ -1052,7 +1052,7 @@ export const OrchestrationCodeBoilerPlate: any = (node: any) => {
         \n if (!tx) {
           throw new Error( 'Tx failed - the commitment was not accepted on-chain, or the contract is not deployed.');
         } \n`;
-      if (!node.newCommitmentsRequired){
+      if (!node.newCommitmentsRequired) {
         checkLeaves = '';
       }
       return {

src/traverse/Indicator.ts

@@ -142,10 +142,11 @@ export class FunctionDefinitionIndicator extends ContractDefinitionIndicator {
     let burnedOnly = true;
     for (const [, stateVarIndicator] of Object.entries(this)) {
       if (!(stateVarIndicator instanceof StateVariableIndicator)) continue; // eslint-disable-line no-continue, no-use-before-define
-      // if we have a indicator which is NOT burned, then we do need new commitments
+      // if we have a indicator which is NOT burned and requires new commitments, then we do need new commitments
       if (
         stateVarIndicator.isSecret &&
-        (!stateVarIndicator.isBurned || stateVarIndicator.newCommitmentsRequired)
+        !stateVarIndicator.isBurned &&
+        stateVarIndicator.newCommitmentsRequired
       ) {
         burnedOnly = false;
         break;