Skip to content

Commit 030c19f

Browse files
authored
Merge pull request #416 from EarthyScience/jp/camera-tweaks
Tweaked camera in Flat-map
2 parents 2220135 + ad7f553 commit 030c19f

File tree

3 files changed

+14
-13
lines changed

3 files changed

+14
-13
lines changed

src/components/plots/Plot.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,10 @@ const TransectNotice = () =>{
2828
}
2929

3030
const Orbiter = ({isFlat} : {isFlat : boolean}) =>{
31-
const {resetCamera, useOrtho} = usePlotStore(useShallow(state => ({
31+
const {resetCamera, useOrtho, displaceSurface} = usePlotStore(useShallow(state => ({
3232
resetCamera: state.resetCamera,
33-
useOrtho: state.useOrtho
33+
useOrtho: state.useOrtho,
34+
displaceSurface: state.displaceSurface
3435
})))
3536
const orbitRef = useRef<OrbitControlsImpl | null>(null)
3637
const hasMounted = useRef(false);
@@ -117,7 +118,7 @@ const Orbiter = ({isFlat} : {isFlat : boolean}) =>{
117118
return (
118119
<OrbitControls
119120
ref={orbitRef}
120-
enableRotate={!isFlat || !useOrtho}
121+
enableRotate={!isFlat || !useOrtho || !displaceSurface}
121122
enablePan={true}
122123
maxDistance={50}
123124
minZoom={1}

src/components/ui/MainPanel/AdjustPlot.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -326,17 +326,19 @@ const PointOptions = () =>{
326326

327327
const FlatOptions = () =>{
328328
const {displacement, displaceSurface, offsetNegatives,
329-
setDisplacement, setDisplaceSurface, setOffsetNegatives} = usePlotStore(useShallow(state=> ({
329+
setDisplacement, setDisplaceSurface, setOffsetNegatives,
330+
setResetCamera} = usePlotStore(useShallow(state=> ({
330331
displacement: state.displacement, displaceSurface: state.displaceSurface,
331332
offsetNegatives: state.offsetNegatives, setDisplacement: state.setDisplacement,
332-
setDisplaceSurface: state.setDisplaceSurface, setOffsetNegatives: state.setOffsetNegatives
333+
setDisplaceSurface: state.setDisplaceSurface, setOffsetNegatives: state.setOffsetNegatives,
334+
setResetCamera: state.setResetCamera
333335
})))
334336
return(
335337
<>
336338
<div className='grid gap-2 mb-2'>
337339
<div
338340
className='relative w-full text-center h-10 bg-primary rounded-full cursor-pointer mb-2 flex items-center justify-between px-4'
339-
onClick={() => {setDisplaceSurface(!displaceSurface);}}
341+
onClick={() => {if (!displaceSurface){setResetCamera(!usePlotStore.getState().resetCamera)}; setDisplaceSurface(!displaceSurface); }}
340342
>
341343
<span className={`z-10 font-semibold transition-colors ${displaceSurface ? 'text-primary' : 'text-secondary'}`}>
342344
Flat

src/components/ui/MainPanel/PlayButton.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -198,8 +198,7 @@ const PlayInterFace = ({visible, setKeepOpen}:{visible : boolean, setKeepOpen: R
198198
<Button
199199
variant='secondary'
200200
size='sm'
201-
className='cursor-pointer'
202-
disabled={zSlice[0] === 0}
201+
className={`cursor-pointer ${zSlice[0] === 0 ? "invisible" : null}`}
203202
onClick={() => {
204203
setZSlice([Math.max(zSlice[0] - chunkTimeLength, 0), zSlice[1]])
205204
setKeepOpen(true)
@@ -214,11 +213,10 @@ const PlayInterFace = ({visible, setKeepOpen}:{visible : boolean, setKeepOpen: R
214213

215214
<div className='text-xs sm:text-sm text-center'>{currentLabel}</div>
216215

217-
<Button
216+
<Button
218217
variant='secondary'
219218
size='sm'
220-
className='cursor-pointer'
221-
disabled={!zSlice[1] || zSlice[1] === timeLength}
219+
className={`cursor-pointer ${!zSlice[1] || zSlice[1] === timeLength? "invisible" : null}`}
222220
onClick={() => {
223221
if (zSlice[1] === null) return
224222
setZSlice([zSlice[0], Math.min(zSlice[1] + chunkTimeLength, timeLength)])
@@ -234,14 +232,14 @@ const PlayInterFace = ({visible, setKeepOpen}:{visible : boolean, setKeepOpen: R
234232
</div>
235233

236234
{/* VISUALIZER */}
237-
<ChunkVisualizer
235+
{(sliceDist < timeLength) && <ChunkVisualizer
238236
zSlice={zSlice}
239237
timeLength={timeLength}
240238
chunkWidth={chunkDivWidth}
241239
showPrev={showPrevChunk}
242240
showNext={showNextChunk}
243241
animProg={animProg}
244-
/>
242+
/>}
245243

246244
{/* SLIDER */}
247245
<div className='flex items-center gap-1 w-full'>

0 commit comments

Comments
 (0)