Skip to content

Commit be209da

Browse files
committed
deleting example directory in tmp dir
1 parent e8c24e2 commit be209da

File tree

4 files changed

+77
-50
lines changed

4 files changed

+77
-50
lines changed

cran-comments.md

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,17 @@
11
## Notes
22
Dear CRAN maintainers,
33

4-
following up the email from Prof. Ripley 3/6/2022, we converted the strong
5-
dependency on package mlegp, which might be archived from CRAN, to a weak
6-
dependency (SUGGESTS).
7-
The parts that use mlegp now use "requireNamespace" and in case display
8-
an error requesting users to install a version of mlegp by hand.
4+
following your email that noted empty documentation for some of the function
5+
arguments, we submit a new version of the REddyProc package.
96

10-
Could you, please, have a look at the current version and tell us if
11-
this weak dependency is ok with CRAN.
12-
13-
Please, do not publish this version on CRAN yet. We still hope that
14-
mlegp gets fixed.
15-
Otherwise we will submit this version again on Fri 18th of March, i.e.
16-
shortly before REddyProc would be archived due to strong dependendy on mlegp.
7+
In addition to fixing the empty comments, we include a new features:
8+
- exporting the results in an additional format requested by a users
9+
- an experimental implementation of the gap-filling procedure by Vekuri et. al 2023
1710

1811
## Test environments
1912
* local Linux-Mint, R 4.3.2
2013
* Github actions, current Ubuntu
21-
* current win_builder
14+
* (win_builder was not reachable by curl from devtools::check_win_devel())
2215
* r_hub: all default platforms
2316

2417
## R CMD check results
@@ -28,5 +21,6 @@ No warnings, nor errors.
2821
"checking for detritus in the temp directory ... NOTE
2922
Found the following files/directories:
3023
‘REddyProcExamples’"
31-
REddyProcExamples is on purpose and not detritus
24+
REddyProcExamples is there on purpose: It is created on a first call to
25+
getExamplePath(exampleId) and then reused by several tests.
3226

inst/genData/sEddyProc.Rd

Lines changed: 32 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,32 @@
1-
\name{sEddyProc}
2-
\alias{sEddyProc}
3-
\title{sEddyProc}
4-
\description{ create an instance of class \code{\link{sEddyProc-class}} }
5-
\usage{sEddyProc(...)}
6-
\arguments{
7-
\item{\dots}{
8-
}
9-
}
10-
11-
12-
13-
\author{(Department for Biogeochemical Integration at MPI-BGC, Jena, Germany)}
14-
15-
16-
17-
18-
1+
\name{sEddyProc}
2+
3+
\alias{sEddyProc}
4+
5+
\title{sEddyProc}
6+
7+
8+
\description{ create an instance of class \code{\link{sEddyProc-class}} }
9+
10+
\usage{sEddyProc(...)}
11+
12+
\arguments{
13+
14+
\item{\dots}{not used.
15+
16+
}
17+
18+
}
19+
20+
21+
\author{(Department for Biogeochemical Integration at MPI-BGC, Jena, Germany)}
22+
23+
24+
25+
26+
27+
28+
29+
30+
31+
32+

man/sEddyProc.Rd

Lines changed: 32 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,32 @@
1-
\name{sEddyProc}
2-
\alias{sEddyProc}
3-
\title{sEddyProc}
4-
\description{ create an instance of class \code{\link{sEddyProc-class}} }
5-
\usage{sEddyProc(...)}
6-
\arguments{
7-
\item{\dots}{
8-
}
9-
}
10-
11-
12-
13-
\author{(Department for Biogeochemical Integration at MPI-BGC, Jena, Germany)}
14-
15-
16-
17-
18-
1+
\name{sEddyProc}
2+
3+
\alias{sEddyProc}
4+
5+
\title{sEddyProc}
6+
7+
8+
\description{ create an instance of class \code{\link{sEddyProc-class}} }
9+
10+
\usage{sEddyProc(...)}
11+
12+
\arguments{
13+
14+
\item{\dots}{not used.
15+
16+
}
17+
18+
}
19+
20+
21+
\author{(Department for Biogeochemical Integration at MPI-BGC, Jena, Germany)}
22+
23+
24+
25+
26+
27+
28+
29+
30+
31+
32+

tests/doRUnit.R

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ if (require("testthat", quietly = TRUE)) {
77
#library(pkg, character.only = TRUE)
88
#test_package(pkg)
99
test_check(pkg)
10+
if (testthat:::on_cran()) {
11+
# delete the tmpdir()/REddyProdExamples to avoid note on detritus in the temp directory
12+
# do not delete it outside cran, to avoid downloading several times
13+
unlink(getREddyProcExampleDir(), recursive=TRUE)
14+
}
1015
} else {
1116
warning("cannot run unit tests -- package testthat is not available")
1217
}

0 commit comments

Comments
 (0)