Skip to content

Conversation

@danlooo
Copy link
Collaborator

@danlooo danlooo commented Jun 11, 2025

This PR removes code that is not being used any more to clean up the codebase and prioritize where to write further unit tests.

@danlooo danlooo changed the title Remove timestats.jl Remove non required code Jun 11, 2025
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.16%. Comparing base (4264210) to head (8bd0ab9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #103       +/-   ##
===========================================
+ Coverage   61.26%   74.16%   +12.89%     
===========================================
  Files           7        6        -1     
  Lines         253      209       -44     
===========================================
  Hits          155      155               
+ Misses         98       54       -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danlooo danlooo merged commit d93555a into main Jun 11, 2025
5 checks passed
@felixcremer
Copy link
Collaborator

You have been a bit too fast with this deletion.
The different rqatrend functions are there for the benchmarking and to show the improvements we did with our current implementation.
The inner_postprocessing function is used for the next step of the data analysis pipeline.

The deletion of the timestats.jl file is fine.

@danlooo
Copy link
Collaborator Author

danlooo commented Jun 13, 2025

OK, can you put it to the test dir instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants