Replace everything by missing if gdalfile throws error #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e data This will allow to read Sentinel-1 data even though one single time step is not available.
With this we can save the RQA trend data in UInt8 data and can apply the threshold on that.
Collaborator
Author
|
This also reintroduces the classification into UInt8 classes. The tests are passing locally. |
This is actually not needed, because we are trying to keep the Path type and don't have to recast it.
meggart
reviewed
Nov 18, 2025
| Compute the RQA trend metric for the non-missing time steps of xin, and save it to xout. | ||
| `thresh` specifies the epsilon threshold of the Recurrence Plot computation | ||
| """ |
Collaborator
There was a problem hiding this comment.
Maybe we should add to the docs that a value between 0 and 254 is returned and 255 corresponds to missing. Also, the kwargs lowerbound and upperbound are not documented
meggart
approved these changes
Nov 18, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 56.76% 66.55% +9.78%
==========================================
Files 6 6
Lines 266 287 +21
==========================================
+ Hits 151 191 +40
+ Misses 115 96 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
felixcremer
force-pushed
the
fc/tiferrors
branch
from
5784109 to
0a6f428
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to read Sentinel-1 data even though one single time step is not available.
This also saves the rqatrend result locally and rechunks it into S3.