-

Author: javiereguiluz

AGENTS.md

@@ -94,6 +94,7 @@ Welcome, 🤖 AI assistant! Please follow these guidelines when contributing to
 - Use the custom Twig components defined in templates/components/ when needed
 - Follow accessibility best practices (e.g. `aria-*, semantic tags, labels)
 - Use trans for all user-facing strings; never hardcode text in templates
+- All translations must be done in Twig templates using `|trans`; avoid translation logic in PHP code (use TranslatableInterface objects that will be translated in templates)
 
 ## JavaScript
 

src/Dto/ActionDto.php

@@ -21,7 +21,7 @@ final class ActionDto
     private ?string $icon = null;
     private string $cssClass = '';
     private string $addedCssClass = '';
-    /** @var array<string, string> */
+    /** @var array<string, string|TranslatableInterface> */
     private array $htmlAttributes = [];
     private ?string $linkUrl = null;
     private ?string $templatePath = null;
@@ -39,7 +39,6 @@ final class ActionDto
     private ButtonType $buttonType = ButtonType::Submit;
     private ButtonVariant $variant = ButtonVariant::Default;
     private ButtonStyle $style = ButtonStyle::Solid;
-    private string|TranslatableInterface|null $batchConfirmationMessage = null;
 
     public function getType(): string
     {
@@ -168,30 +167,30 @@ public function setButtonType(ButtonType $buttonType): void
     }
 
     /**
-     * @return array<string, string>
+     * @return array<string, string|TranslatableInterface>
      */
     public function getHtmlAttributes(): array
     {
         return $this->htmlAttributes;
     }
 
     /**
-     * @param array<string, string> $htmlAttributes
+     * @param array<string, string|TranslatableInterface> $htmlAttributes
      */
     public function addHtmlAttributes(array $htmlAttributes): void
     {
         $this->htmlAttributes = array_merge($this->htmlAttributes, $htmlAttributes);
     }
 
     /**
-     * @param array<string, string> $htmlAttributes
+     * @param array<string, string|TranslatableInterface> $htmlAttributes
      */
     public function setHtmlAttributes(array $htmlAttributes): void
     {
         $this->htmlAttributes = $htmlAttributes;
     }
 
-    public function setHtmlAttribute(string $attributeName, string $attributeValue): void
+    public function setHtmlAttribute(string $attributeName, string|TranslatableInterface $attributeValue): void
     {
         $this->htmlAttributes[$attributeName] = $attributeValue;
     }
@@ -355,16 +354,6 @@ public function usesTextStyle(): bool
         return ButtonStyle::Text === $this->style;
     }
 
-    public function getBatchConfirmationMessage(): string|TranslatableInterface|null
-    {
-        return $this->batchConfirmationMessage;
-    }
-
-    public function setBatchConfirmationMessage(string|TranslatableInterface|null $message): void
-    {
-        $this->batchConfirmationMessage = $message;
-    }
-
     /**
      * @internal
      */

src/Factory/ActionFactory.php

@@ -229,7 +229,9 @@ private function processAction(string $pageName, ActionDto $actionDto, ?EntityDt
 
                 // if the confirmation config is not a boolean, it's a string or TranslatableInterface with the custom confirmation message
                 if (true !== $confirmationConfig) {
-                    $actionDto->setBatchConfirmationMessage($confirmationConfig);
+                    $batchActionAttributes['data-batch-action-confirm-message'] = $confirmationConfig instanceof TranslatableInterface
+                        ? $confirmationConfig
+                        : t($confirmationConfig, $defaultTranslationParameters, $translationDomain);
                 }
             }
 

templates/crud/action.html.twig

@@ -2,16 +2,11 @@
 {# @var action \EasyCorp\Bundle\EasyAdminBundle\Dto\ActionDto #}
 {# @var entity \EasyCorp\Bundle\EasyAdminBundle\Dto\EntityDto #}
 
-{% set html_attributes = action.htmlAttributes %}
-{% if action.batchConfirmationMessage is not null %}
-    {% set html_attributes = html_attributes|merge({'data-batch-action-confirm-message': action.batchConfirmationMessage|trans}) %}
-{% endif %}
-
 <twig:ea:Button
     variant="{{ action.variant }}"
     isInvisible="{{ action.usesTextStyle }}"
     class="{{ action.htmlElement.isLink and isIncludedInDropdown|default(false) ? 'dropdown-item' }} {{ action.cssClass }}"
-    htmlAttributes="{{ html_attributes }}"
+    htmlAttributes="{{ action.htmlAttributes }}"
     htmlElement="{{ action.htmlElement }}"
     type="{{ action.buttonType.value }}"
     icon="{{ action.icon }}"