feature #7336 Allow to disable and customize the confirmation message of batch actions (javiereguiluz)

This PR was squashed before being merged into the 4.x branch.

Discussion
----------

Allow to disable and customize the confirmation message of batch actions

Commits
-------

578aa36 Allow to disable and customize the confirmation message of batch actions

Author: javiereguiluz

AGENTS.md

@@ -94,6 +94,7 @@ Welcome, 🤖 AI assistant! Please follow these guidelines when contributing to
 - Use the custom Twig components defined in templates/components/ when needed
 - Follow accessibility best practices (e.g. `aria-*, semantic tags, labels)
 - Use trans for all user-facing strings; never hardcode text in templates
+- All translations must be done in Twig templates using `|trans`; avoid translation logic in PHP code (use TranslatableInterface objects that will be translated in templates)
 
 ## JavaScript
 

assets/js/app.js

@@ -328,21 +328,16 @@ class App {
         });
 
         const modalTitle = document.querySelector('#batch-action-confirmation-title');
-        const titleContentWithPlaceholders = modalTitle.textContent;
+        const titleContentWithPlaceholders = modalTitle?.textContent;
 
         document.querySelectorAll('[data-action-batch]').forEach((dataActionBatch) => {
             dataActionBatch.addEventListener('click', (event) => {
                 event.preventDefault();
 
                 const actionElement = event.currentTarget;
-                // There is still a possibility that actionName will remain undefined. The title attribute is not always present on elements with the [data-action-batch] attribute.
-                const actionName = actionElement.textContent.trim() || actionElement.getAttribute('title');
                 const selectedItems = document.querySelectorAll('input[type="checkbox"].form-batch-checkbox:checked');
-                modalTitle.textContent = titleContentWithPlaceholders
-                    .replace('%action_name%', actionName)
-                    .replace('%num_items%', selectedItems.length.toString());
 
-                document.querySelector('#modal-batch-action-button').addEventListener('click', () => {
+                const submitBatchAction = () => {
                     // prevent double submission of the batch action form
                     actionElement.setAttribute('disabled', 'disabled');
 
@@ -369,7 +364,25 @@ class App {
 
                     document.body.appendChild(batchForm);
                     batchForm.submit();
-                });
+                };
+
+                // check if this batch action should skip confirmation
+                if (actionElement.hasAttribute('data-action-batch-no-confirm')) {
+                    submitBatchAction();
+                } else {
+                    // show confirmation modal
+                    const actionName = actionElement.textContent.trim() || actionElement.getAttribute('title');
+
+                    // use custom message if provided, otherwise use default modal title
+                    const customMessage = actionElement.getAttribute('data-batch-action-confirm-message');
+                    const messageTemplate = customMessage ?? titleContentWithPlaceholders;
+
+                    modalTitle.textContent = messageTemplate
+                        .replace('%action_name%', actionName)
+                        .replace('%num_items%', selectedItems.length.toString());
+
+                    document.querySelector('#modal-batch-action-button').addEventListener('click', submitBatchAction);
+                }
             });
         });
     }

doc/actions.rst

@@ -773,6 +773,58 @@ If you do that, EasyAdmin will inject a DTO with all the batch action data::
     also inject Symfony's ``Request`` object to get all the raw submitted batch data
     (e.g. ``$request->request->all('batchActionEntityIds')``).
 
+Batch Action Confirmation
+~~~~~~~~~~~~~~~~~~~~~~~~~
+
+By default, batch actions display a confirmation modal before execution to prevent
+accidental operations on multiple items. You can configure this behavior at the
+dashboard level (for all CRUD controllers) or at the individual CRUD controller
+level (to override the dashboard default).
+
+To disable the confirmation modal entirely::
+
+    namespace App\Controller\Admin;
+
+    use EasyCorp\Bundle\EasyAdminBundle\Config\Crud;
+    use EasyCorp\Bundle\EasyAdminBundle\Controller\AbstractCrudController;
+
+    class ProductCrudController extends AbstractCrudController
+    {
+        // ...
+
+        public function configureCrud(Crud $crud): Crud
+        {
+            return $crud
+                // batch actions will be executed immediately without confirmation
+                ->askConfirmationOnBatchActions(false)
+            ;
+        }
+    }
+
+You can also customize the confirmation message by passing a string instead of
+a boolean. The message supports two placeholders: ``%action_name%`` (the name of
+the batch action being executed) and ``%num_items%`` (the number of selected items)::
+
+    public function configureCrud(Crud $crud): Crud
+    {
+        return $crud
+            ->askConfirmationOnBatchActions(
+                'Are you sure you want to apply "%action_name%" to %num_items% products?'
+            )
+        ;
+    }
+
+For translatable messages, you can pass a ``TranslatableInterface`` object::
+
+    use function Symfony\Component\Translation\t;
+
+    public function configureCrud(Crud $crud): Crud
+    {
+        return $crud
+            ->askConfirmationOnBatchActions(t('batch.confirm.message'))
+        ;
+    }
+
 .. _actions-integrating-symfony:
 
 Integrating Symfony Actions

public/app.dc113b51.js public/app.8222474a.jspublic/app.dc113b51.js renamed to public/app.8222474a.js

@@ -5,7 +5,7 @@
         "/app.f9f0ca7b.css"
       ],
       "js": [
-        "/app.dc113b51.js"
+        "/app.8222474a.js"
       ]
     },
     "form": {

public/app.dc113b51.js.LICENSE.txt public/app.8222474a.js.LICENSE.txtpublic/app.dc113b51.js.LICENSE.txt renamed to public/app.8222474a.js.LICENSE.txt

@@ -1,6 +1,6 @@
 {
   "app.css": "app.f9f0ca7b.css",
-  "app.js": "app.dc113b51.js",
+  "app.js": "app.8222474a.js",
   "form.js": "form.875c88d4.js",
   "page-layout.js": "page-layout.6e9fe55d.js",
   "page-color-scheme.js": "page-color-scheme.30cb23c2.js",

public/entrypoints.json

@@ -437,6 +437,19 @@ public function hideNullValues(bool $hide = true): self
         return $this;
     }
 
+    /**
+     * By default, batch actions show a confirmation modal before execution.
+     * Set to false to execute batch actions immediately without confirmation.
+     * Set to a string (or TranslatableInterface) to show a custom confirmation message.
+     * The message can use placeholders: %action_name% and %num_items%.
+     */
+    public function askConfirmationOnBatchActions(bool|string|TranslatableInterface $askConfirmation = true): self
+    {
+        $this->dto->setAskConfirmationOnBatchActions($askConfirmation);
+
+        return $this;
+    }
+
     public function getAsDto(): CrudDto
     {
         $this->dto->setPaginator(new PaginatorDto($this->paginatorPageSize, $this->paginatorRangeSize, 1, $this->paginatorFetchJoinCollection, $this->paginatorUseOutputWalkers));

public/manifest.json

@@ -21,7 +21,7 @@ final class ActionDto
     private ?string $icon = null;
     private string $cssClass = '';
     private string $addedCssClass = '';
-    /** @var array<string, string> */
+    /** @var array<string, string|TranslatableInterface> */
     private array $htmlAttributes = [];
     private ?string $linkUrl = null;
     private ?string $templatePath = null;
@@ -167,30 +167,30 @@ public function setButtonType(ButtonType $buttonType): void
     }
 
     /**
-     * @return array<string, string>
+     * @return array<string, string|TranslatableInterface>
      */
     public function getHtmlAttributes(): array
     {
         return $this->htmlAttributes;
     }
 
     /**
-     * @param array<string, string> $htmlAttributes
+     * @param array<string, string|TranslatableInterface> $htmlAttributes
      */
     public function addHtmlAttributes(array $htmlAttributes): void
     {
         $this->htmlAttributes = array_merge($this->htmlAttributes, $htmlAttributes);
     }
 
     /**
-     * @param array<string, string> $htmlAttributes
+     * @param array<string, string|TranslatableInterface> $htmlAttributes
      */
     public function setHtmlAttributes(array $htmlAttributes): void
     {
         $this->htmlAttributes = $htmlAttributes;
     }
 
-    public function setHtmlAttribute(string $attributeName, string $attributeValue): void
+    public function setHtmlAttribute(string $attributeName, string|TranslatableInterface $attributeValue): void
     {
         $this->htmlAttributes[$attributeName] = $attributeValue;
     }

src/Config/Crud.php

@@ -78,6 +78,7 @@ final class CrudDto
     private ?string $contentWidth = null;
     private ?string $sidebarWidth = null;
     private bool $hideNullValues = false;
+    private bool|string|TranslatableInterface $askConfirmationOnBatchActions = true;
 
     public function __construct()
     {
@@ -597,4 +598,14 @@ public function hideNullValues(bool $hide): void
     {
         $this->hideNullValues = $hide;
     }
+
+    public function askConfirmationOnBatchActions(): bool|string|TranslatableInterface
+    {
+        return $this->askConfirmationOnBatchActions;
+    }
+
+    public function setAskConfirmationOnBatchActions(bool|string|TranslatableInterface $askConfirmation): void
+    {
+        $this->askConfirmationOnBatchActions = $askConfirmation;
+    }
 }