Skip to content

Commit 1dd2874

Browse files
committed
Remove support containers from global migration
Signed-off-by: Riddhesh Sanghvi <[email protected]>
1 parent d87a7be commit 1dd2874

File tree

2 files changed

+0
-52
lines changed

2 files changed

+0
-52
lines changed

php/EE/Migration/Containers.php

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -200,17 +200,6 @@ private static function migrate_global_containers( $updated_images ) {
200200
[ $global_compose_file_backup_path, $global_compose_file_path, $updated_global_images ]
201201
);
202202

203-
/**
204-
* Create support containers.
205-
*/
206-
self::$rsp->add_step(
207-
'create-support-global-containers',
208-
'EE\Migration\GlobalContainers::enable_support_containers',
209-
'EE\Migration\GlobalContainers::disable_support_containers',
210-
null,
211-
null
212-
);
213-
214203
self::$rsp->add_step(
215204
'stop-global-containers',
216205
'EE\Migration\GlobalContainers::down_global_containers',
@@ -240,17 +229,6 @@ private static function migrate_global_containers( $updated_images ) {
240229
[ $global_service_name ]
241230
);
242231
}
243-
244-
/**
245-
* Remove support containers.
246-
*/
247-
self::$rsp->add_step(
248-
'remove-support-global-containers',
249-
'EE\Migration\GlobalContainers::disable_support_containers',
250-
'EE\Migration\GlobalContainers::enable_support_containers',
251-
null,
252-
null
253-
);
254232
}
255233

256234
/**

php/EE/Migration/GlobalContainers.php

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -137,34 +137,4 @@ public static function get_all_global_images_with_service_name() {
137137
'easyengine/newrelic-daemon' => GLOBAL_NEWRELIC_DAEMON_CONTAINER,
138138
];
139139
}
140-
141-
/**
142-
* Create support containers for global-db and global-redis service.
143-
*/
144-
public static function enable_support_containers() {
145-
if ( ! chdir( EE_SERVICE_DIR ) ) {
146-
throw new \Exception( sprintf( '%s path does not exist', EE_SERVICE_DIR ) );
147-
}
148-
149-
$command = \EE_DOCKER::docker_compose_with_custom() . ' --project-name=ee up -d global-db global-redis';
150-
if ( ! EE::exec( $command ) ) {
151-
throw new \Exception( 'Unable to create support container.' );
152-
}
153-
}
154-
155-
/**
156-
* Remove support containers for global-db and global-redis service.
157-
*/
158-
public static function disable_support_containers() {
159-
if ( ! chdir( EE_SERVICE_DIR ) ) {
160-
throw new \Exception( sprintf( '%s path does not exist', EE_SERVICE_DIR ) );
161-
}
162-
163-
$command = \EE_DOCKER::docker_compose_with_custom() . ' --project-name=ee down';
164-
/**
165-
* Return code can be 1 due to error in removing network. This is expected.
166-
* TODO: Get a fix for global network / make them external so that the return code is not 1.
167-
*/
168-
EE::exec( $command );
169-
}
170140
}

0 commit comments

Comments
 (0)