Skip to content

Commit e16f4b9

Browse files
authored
Merge pull request #1633 from mrrobot47/fix/migration-for-site-limit-update
Update global container migration in accordance to site-limit update changes
2 parents 7537a42 + 3dca583 commit e16f4b9

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

php/EE/Migration/GlobalContainers.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,10 @@ public static function disable_support_containers() {
164164
}
165165

166166
$command = \EE_DOCKER::docker_compose_with_custom() . ' --project-name=ee down';
167-
if ( ! EE::exec( $command ) ) {
168-
throw new \Exception( 'Unable to remove support container.' );
169-
}
167+
/**
168+
* Return code can be 1 due to error in removing network. This is expected.
169+
* TODO: Get a fix for global network / make them external so that the return code is not 1.
170+
*/
171+
EE::exec( $command );
170172
}
171173
}

0 commit comments

Comments
 (0)