Fix site deletion when ssl is not issued #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the SSL certificate authorization and verification flow to improve error handling and user guidance. Instead of throwing exceptions on failed SSL operations, the code now provides clear warnings, logs actionable messages, and returns
falseto indicate failure. This ensures that site creation and SSL processes can fail gracefully, and users receive instructions on how to resolve issues and retry.Error handling and user guidance improvements:
Site_Letsencrypt.php, guiding users to re-runee site ssl-verifyafter fixing issues. [1] [2] [3] [4] [5] [6]class-ee-site.phpto setsite_ssltonulland display warnings when failures occur, ensuring sites are created without SSL if necessary and users are informed how to proceed. [1] [2] [3]Return value consistency:
trueon success andfalseon failure in SSL-related methods, enabling better flow control and error handling in calling code. [1] [2] [3]Minor code improvements:
check_www_or_non_www_domainfor clarity.