Skip to content

Fix/cert return #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

Fix/cert return #453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e9ba01
feat(letsencrypt): return true after moving certs to Nginx proxy
mrrobot47 Sep 26, 2025
8d93a25
feat(letsencrypt): return true after cert renewal
mrrobot47 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/helper/Site_Letsencrypt.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,8 @@ private function executeFirstRequest( $domain, array $alternativeNames, $email )

// Post-generate actions
$this->moveCertsToNginxProxy( $domain );

return true;
}

private function moveCertsToNginxProxy( string $domain ) {
Expand Down Expand Up @@ -636,6 +638,8 @@ private function executeRenewal( $domain, array $alternativeNames, $force = fals
$this->moveCertsToNginxProxy( $domain );
\EE::log( 'Certificate renewed successfully!' );

return true;

} catch ( \Exception $e ) {
\EE::warning( 'A critical error occured during certificate renewal' );
\EE::debug( print_r( $e, true ) );
Expand Down
Loading