Fix a regression bug caused by accidentally removed lock-protected ref-counting in Ime::Module.

PCMan · PCMan · commit 592b8d8d4c41 · 2017-05-08T03:12:07.000+08:00
diff --git a/ImeModule.cpp b/ImeModule.cpp
@@ -505,11 +505,11 @@ STDMETHODIMP_(ULONG) ImeModule::Release(void) {
 	// The last reference is released in DllMain() when unloading.
 	// Hence interlocked operations are enough here, I guess.
 	assert(refCount_ > 0);
-	const ULONG newCount = --refCount_;
 	if(::InterlockedExchangeSubtract(&refCount_, 1) == 1) {
 		delete this;
+		return 0;
 	}
-	return newCount;
+	return refCount_;
 }
 
 // IClassFactory

Original file line number	Diff line number	Diff line change
`@@ -505,11 +505,11 @@ STDMETHODIMP_(ULONG) ImeModule::Release(void) {`
`505`	`505`	`// The last reference is released in DllMain() when unloading.`
`506`	`506`	`// Hence interlocked operations are enough here, I guess.`
`507`	`507`	`assert(refCount_ > 0);`
`508`		`- const ULONG newCount = --refCount_;`
`509`	`508`	`if(::InterlockedExchangeSubtract(&refCount_, 1) == 1) {`
`510`	`509`	`delete this;`
	`510`	`+ return 0;`
`511`	`511`	`}`
`512`		`- return newCount;`
	`512`	`+ return refCount_;`
`513`	`513`	`}`
`514`	`514`
`515`	`515`	`// IClassFactory`