refactor: Small refactor

Author: oxyno-zeta

internal/controller/postgresql/postgres/database.go

@@ -34,16 +34,6 @@ AND     n.nspname = '%s';`
 	DuplicateDatabaseErrorCode = "42P04"
 )
 
-type TableOwnership struct {
-	TableName string
-	Owner     string
-}
-
-type TypeOwnership struct {
-	TypeName string
-	Owner    string
-}
-
 func (c *pg) IsDatabaseExist(dbname string) (bool, error) {
 	err := c.connect(c.defaultDatabase)
 	if err != nil {

internal/controller/postgresql/postgres/postgres.go

@@ -15,6 +15,16 @@ type SetRoleOnDatabaseRoleSetting struct {
 	Database string
 }
 
+type TableOwnership struct {
+	TableName string
+	Owner     string
+}
+
+type TypeOwnership struct {
+	TypeName string
+	Owner    string
+}
+
 type PG interface { //nolint:interfacebloat // This is needed
 	CreateDB(dbname, username string) error
 	ChangeDBOwner(dbname, owner string) error

internal/controller/postgresql/postgresqldatabase_controller.go

@@ -311,9 +311,12 @@ func (r *PostgresqlDatabaseReconciler) manageDropDatabase(
 
 	// Drop roles first
 
+	// Init variable
+	var exists bool
+
 	// Drop owner
 	if instance.Status.Roles.Owner != "" {
-		exists, err := pg.IsRoleExist(instance.Status.Roles.Owner)
+		exists, err = pg.IsRoleExist(instance.Status.Roles.Owner)
 		// Check error
 		if err != nil {
 			return err
@@ -331,7 +334,7 @@ func (r *PostgresqlDatabaseReconciler) manageDropDatabase(
 	}
 	// Drop writer
 	if instance.Status.Roles.Writer != "" {
-		exists, err := pg.IsRoleExist(instance.Status.Roles.Writer)
+		exists, err = pg.IsRoleExist(instance.Status.Roles.Writer)
 		// Check error
 		if err != nil {
 			return err
@@ -349,7 +352,7 @@ func (r *PostgresqlDatabaseReconciler) manageDropDatabase(
 	}
 	// Drop reader
 	if instance.Status.Roles.Reader != "" {
-		exists, err := pg.IsRoleExist(instance.Status.Roles.Reader)
+		exists, err = pg.IsRoleExist(instance.Status.Roles.Reader)
 		// Check error
 		if err != nil {
 			return err