feat: wip

Author: oxyno-zeta

internal/controller/postgresql/postgresqlbackup_controller_test.go

@@ -17,69 +17,59 @@ limitations under the License.
 package postgresql
 
 import (
-	"context"
-
-	"k8s.io/apimachinery/pkg/api/errors"
-	"k8s.io/apimachinery/pkg/types"
-	"sigs.k8s.io/controller-runtime/pkg/reconcile"
-
 	. "github.com/onsi/ginkgo/v2"
-	. "github.com/onsi/gomega"
-
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-
-	postgresqlv1alpha1 "github.com/easymile/postgresql-operator/api/postgresql/v1alpha1"
+	// . "github.com/onsi/gomega".
 )
 
 var _ = Describe("PostgresqlBackup Controller", func() {
-	Context("When reconciling a resource", func() {
-		const resourceName = "test-resource"
-
-		ctx := context.Background()
-
-		typeNamespacedName := types.NamespacedName{
-			Name:      resourceName,
-			Namespace: "default", // TODO(user):Modify as needed
-		}
-		postgresqlbackup := &postgresqlv1alpha1.PostgresqlBackup{}
-
-		BeforeEach(func() {
-			By("creating the custom resource for the Kind PostgresqlBackup")
-			err := k8sClient.Get(ctx, typeNamespacedName, postgresqlbackup)
-			if err != nil && errors.IsNotFound(err) {
-				resource := &postgresqlv1alpha1.PostgresqlBackup{
-					ObjectMeta: metav1.ObjectMeta{
-						Name:      resourceName,
-						Namespace: "default",
-					},
-					// TODO(user): Specify other spec details if needed.
-				}
-				Expect(k8sClient.Create(ctx, resource)).To(Succeed())
-			}
-		})
-
-		AfterEach(func() {
-			// TODO(user): Cleanup logic after each test, like removing the resource instance.
-			resource := &postgresqlv1alpha1.PostgresqlBackup{}
-			err := k8sClient.Get(ctx, typeNamespacedName, resource)
-			Expect(err).NotTo(HaveOccurred())
-
-			By("Cleanup the specific resource instance PostgresqlBackup")
-			Expect(k8sClient.Delete(ctx, resource)).To(Succeed())
-		})
-		It("should successfully reconcile the resource", func() {
-			By("Reconciling the created resource")
-			controllerReconciler := &PostgresqlBackupReconciler{
-				Client: k8sClient,
-				Scheme: k8sClient.Scheme(),
-			}
-
-			_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
-				NamespacedName: typeNamespacedName,
-			})
-			Expect(err).NotTo(HaveOccurred())
-			// TODO(user): Add more specific assertions depending on your controller's reconciliation logic.
-			// Example: If you expect a certain status condition after reconciliation, verify it here.
-		})
-	})
+	// Context("When reconciling a resource", func() {
+	// 	const resourceName = "test-resource"
+
+	// 	ctx := context.Background()
+
+	// 	typeNamespacedName := types.NamespacedName{
+	// 		Name:      resourceName,
+	// 		Namespace: "default", // TODO(user):Modify as needed
+	// 	}
+	// 	postgresqlbackup := &postgresqlv1alpha1.PostgresqlBackup{}
+
+	// 	BeforeEach(func() {
+	// 		By("creating the custom resource for the Kind PostgresqlBackup")
+	// 		err := k8sClient.Get(ctx, typeNamespacedName, postgresqlbackup)
+	// 		if err != nil && errors.IsNotFound(err) {
+	// 			resource := &postgresqlv1alpha1.PostgresqlBackup{
+	// 				ObjectMeta: metav1.ObjectMeta{
+	// 					Name:      resourceName,
+	// 					Namespace: "default",
+	// 				},
+	// 				// TODO(user): Specify other spec details if needed.
+	// 			}
+	// 			Expect(k8sClient.Create(ctx, resource)).To(Succeed())
+	// 		}
+	// 	})
+
+	// 	AfterEach(func() {
+	// 		// TODO(user): Cleanup logic after each test, like removing the resource instance.
+	// 		resource := &postgresqlv1alpha1.PostgresqlBackup{}
+	// 		err := k8sClient.Get(ctx, typeNamespacedName, resource)
+	// 		Expect(err).NotTo(HaveOccurred())
+
+	// 		By("Cleanup the specific resource instance PostgresqlBackup")
+	// 		Expect(k8sClient.Delete(ctx, resource)).To(Succeed())
+	// 	})
+	// 	It("should successfully reconcile the resource", func() {
+	// 		By("Reconciling the created resource")
+	// 		controllerReconciler := &PostgresqlBackupReconciler{
+	// 			Client: k8sClient,
+	// 			Scheme: k8sClient.Scheme(),
+	// 		}
+
+	// 		_, err := controllerReconciler.Reconcile(ctx, reconcile.Request{
+	// 			NamespacedName: typeNamespacedName,
+	// 		})
+	// 		Expect(err).NotTo(HaveOccurred())
+	// 		// TODO(user): Add more specific assertions depending on your controller's reconciliation logic.
+	// 		// Example: If you expect a certain status condition after reconciliation, verify it here.
+	// 	})
+	// })
 })

internal/controller/postgresql/postgresqlbackupprovider_controller.go

@@ -225,15 +225,15 @@ func (r *PostgresqlBackupProviderReconciler) validateInstance(
 		return errors.NewBadRequest("cronjob name mustn't be empty")
 	}
 	if len(instance.Spec.CronJobName) > maxNameLength {
-		return errors.NewBadRequest("cronjob name is greater than supported")
+		return errors.NewBadRequest("cronjob name length is greater than supported")
 	}
 
 	// Check generated name prefix
 	if instance.Spec.GeneratedNamePrefix == "" {
 		return errors.NewBadRequest("GeneratedNamePrefix mustn't be empty")
 	}
 	if len(instance.Spec.GeneratedNamePrefix) > maxGeneratedNamePrefixLength {
-		return errors.NewBadRequest("GeneratedNamePrefix is greater than supported")
+		return errors.NewBadRequest("GeneratedNamePrefix length is greater than supported")
 	}
 
 	// Default