feat: wip

Author: oxyno-zeta

.golangci.yml

@@ -32,7 +32,6 @@ linters:
     - errname
     - exhaustive
     - forcetypeassert
-    - gochecknoinits
     - gochecksumtype
     - goconst
     - gocritic
@@ -97,6 +96,7 @@ linters:
     - lll
     - funcorder
     - nilnil
+    - gochecknoinits
   settings:
     godox:
       # report any comments starting with keywords, this is useful for TODO or FIXME comments that
@@ -387,9 +387,6 @@ linters:
       - legacy
       - std-error-handling
     rules:
-      - linters:
-          - gochecknoinits
-        path: cmd/.*
       - linters:
           - lll
           - govet
@@ -405,6 +402,7 @@ linters:
           - mnd
           - dupl
           - gosec
+          - goconst
         path: internal/controller/.*/.*_test\.go
       - linters:
           - revive

internal/controller/postgresql/postgresqluserrole_controller.go

@@ -781,6 +781,7 @@ func (*PostgresqlUserRoleReconciler) getDBRoleFromPrivilege(
 	dbInstance *v1alpha1.PostgresqlDatabase,
 	userRolePrivilege *v1alpha1.PostgresqlUserRolePrivilege,
 ) string {
+	//nolint:exhaustive
 	switch userRolePrivilege.Privilege {
 	case v1alpha1.ReaderPrivilege:
 		return dbInstance.Status.Roles.Reader

internal/controller/postgresql/postgresqluserrole_controller_test.go

@@ -5517,7 +5517,7 @@ var _ = Describe("PostgresqlUserRole tests", func() {
 			item2 := &v1alpha1.PostgresqlUserRole{}
 			Eventually(
 				func() error {
-					k8sClient.Get(ctx, types.NamespacedName{
+					err = k8sClient.Get(ctx, types.NamespacedName{
 						Name:      pgurName,
 						Namespace: pgurNamespace,
 					}, item2)
@@ -5554,7 +5554,7 @@ var _ = Describe("PostgresqlUserRole tests", func() {
 			item3 := &v1alpha1.PostgresqlUserRole{}
 			Eventually(
 				func() error {
-					k8sClient.Get(ctx, types.NamespacedName{
+					err = k8sClient.Get(ctx, types.NamespacedName{
 						Name:      pgurName,
 						Namespace: pgurNamespace,
 					}, item3)

internal/controller/postgresql/suite_test.go

@@ -992,7 +992,7 @@ func deletePGPublication(ctx context.Context, cl client.Client, name, namespace
 
 func deleteSQLDBs(name string) error {
 	// Query template
-	GetAllCreatedSQLDBTemplate := "SELECT datname FROM pg_database WHERE datname LIKE '%" + name + "%';"
+	getAllCreatedSQLDBTemplate := "SELECT datname FROM pg_database WHERE datname LIKE '%" + name + "%';"
 
 	if mainDBConn == nil {
 		db, err := sql.Open("postgres", postgresUrl)
@@ -1003,7 +1003,7 @@ func deleteSQLDBs(name string) error {
 		mainDBConn = db
 	}
 
-	res, err := mainDBConn.Query(GetAllCreatedSQLDBTemplate)
+	res, err := mainDBConn.Query(getAllCreatedSQLDBTemplate)
 	if err != nil {
 		return err
 	}