Drop IConsumerDispatcher.QueueAction(Action) (#1044)

* Drop legacy method

* Protect from very unlikely weird situation when action throws OCE

* Fix review comments

Author: Pliner

Source/EasyNetQ/Consumer/ConsumerDispatcher.cs

@@ -16,7 +16,6 @@ public ConsumerDispatcher(ConnectionConfiguration configuration)
         {
             Preconditions.CheckNotNull(configuration, "configuration");
 
-
             var thread = new Thread(_ =>
             {
                 var blockingCollections = new[] {durableActions, transientActions};
@@ -28,7 +27,7 @@ public ConsumerDispatcher(ConnectionConfiguration configuration)
                         );
                         action();
                     }
-                    catch (OperationCanceledException)
+                    catch (OperationCanceledException) when (cancellation.IsCancellationRequested)
                     {
                         break;
                     }
@@ -52,12 +51,7 @@ public ConsumerDispatcher(ConnectionConfiguration configuration)
             thread.Start();
         }
 
-        public void QueueAction(Action action)
-        {
-            QueueAction(action, false);
-        }
-
-        public void QueueAction(Action action, bool surviveDisconnect)
+        public void QueueAction(Action action, bool surviveDisconnect = false)
         {
             Preconditions.CheckNotNull(action, "action");
 

Source/EasyNetQ/Consumer/IConsumerDispatcher.cs

@@ -4,8 +4,7 @@ namespace EasyNetQ.Consumer
 {
     public interface IConsumerDispatcher : IDisposable
     {
-        void QueueAction(Action action);
-        void QueueAction(Action action, bool surviveDisconnect);
+        void QueueAction(Action action, bool surviveDisconnect = false);
         void OnDisconnected();
     }
 }