fix: error parsing

Author: Justintime50

CHANGELOG.md

@@ -3,6 +3,9 @@
 ## Next Release (minor)
 
 - Adds Ruby 3.4 support
+- Fixes error parsing
+  - Allows for alternative format of `errors` field
+  - Corrects available properties of an `EasyPostError` and `ApiError` (`code` and `field` removed from `EasyPostError`, `message` unfurled and explicitly added to `ApiError`)
 - Corrects the HTTP verb for updating a brand from `GET` to `PATCH`
 - Removes the deprecated `create_list` tracker endpoint function as it is no longer available via API
 

lib/easypost/errors/api/api_error.rb

@@ -4,10 +4,13 @@
 require 'easypost/constants'
 
 class EasyPost::Errors::ApiError < EasyPost::Errors::EasyPostError
-  attr_reader :status_code, :code, :errors
+  attr_reader :message, :status_code, :code, :errors
 
   def initialize(message, status_code = nil, error_code = nil, sub_errors = nil)
     super message
+    message_list = []
+    EasyPost::Errors::ApiError.collect_error_messages(message, message_list)
+    @message = message_list.join(', ')
     @status_code = status_code
     @code = error_code
     @errors = sub_errors
@@ -46,12 +49,9 @@ def self.handle_api_error(response)
     # Try to parse the response body as JSON
     begin
       error_data = JSON.parse(response.body)['error']
-
       error_message = error_data['message']
       error_type = error_data['code']
-      errors = error_data['errors']&.map do |error|
-        EasyPost::Models::Error.from_api_error_response(error)
-      end
+      errors = error_data['errors']
     rescue StandardError
       error_message = response.code.to_s
       error_type = EasyPost::Constants::API_ERROR_DETAILS_PARSING_ERROR

lib/easypost/models/error.rb

@@ -2,20 +2,10 @@
 
 # EasyPost Error object.
 class EasyPost::Models::Error
-  attr_reader :code, :field, :message
+  attr_reader :message
 
   # Initialize a new EasyPost Error
-  def initialize(code, field = nil, message = nil)
-    @code = code
-    @field = field
+  def initialize(message = nil)
     @message = message
   end
-
-  # Create an EasyPost Error from an API error response.
-  def self.from_api_error_response(data)
-    code = data['code']
-    field = data['field'] || nil
-    message = data['message'] || nil
-    EasyPost::Models::Error.new(code, field, message)
-  end
 end