Skip to content

Reviews result in two messages being sent #26

@Ghabry

Description

@Ghabry

Looks like Github changed slightly the interface for reviews:

In my previous commit I fixed a 500 error when an empty body is received but this results now in two messages.

e.g.

> carstene1ns reviewed pull request 490
> carstene1ns commented on pull request 490
> [The review message]

The documentation of the API is lacking so I'm just guessing a bit here what would make sense in handling this. 😅


When it's a pull_request_review: These always have empty body payloads now (null).

Ignore them, except when review.state is approved or changes_requested.

review.state == commented is the part that spams now.


When it's a pull_request_review_comment: No changes required.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions