Fix more warnings

Author: Ghabry

src/audio_midi.cpp

@@ -84,6 +84,8 @@ std::unique_ptr<AudioDecoderBase> MidiDecoder::CreateFluidsynth(bool resample) {
 	if (mididec && resample) {
 		mididec = std::make_unique<AudioResampler>(std::move(mididec));
 	}
+#else
+	(void)resample;
 #endif
 
 	return mididec;
@@ -107,6 +109,8 @@ std::unique_ptr<AudioDecoderBase> MidiDecoder::CreateWildMidi(bool resample) {
 	if (mididec && resample) {
 		mididec = std::make_unique<AudioResampler>(std::move(mididec));
 	}
+#else
+	(void)resample;
 #endif
 
 	return mididec;
@@ -126,6 +130,8 @@ std::unique_ptr<AudioDecoderBase> MidiDecoder::CreateFmMidi(bool resample) {
 	if (mididec && resample) {
 		mididec = std::make_unique<AudioResampler>(std::move(mididec));
 	}
+#else
+	(void)resample;
 #endif
 
 	return mididec;
@@ -152,6 +158,8 @@ void MidiDecoder::ChangeFluidsynthSoundfont(StringView sf_path) {
 	// Was initialized before
 	works.fluidsynth = FluidSynthDecoder::ChangeGlobalSoundfont(sf_path, works.fluidsynth_status);
 	Output::Debug("Fluidsynth: {}", works.fluidsynth_status);
+#else
+	(void)sf_path;
 #endif
 }
 

src/game_battlealgorithm.cpp

@@ -62,9 +62,10 @@ Game_BattleAlgorithm::AlgorithmBase::AlgorithmBase(Type ty, Game_Battler* source
 	type(ty), source(source), targets(std::move(in_targets))
 {
 	assert(source != nullptr);
-	for (auto* t: targets) {
-		assert(t != nullptr);
-	}
+
+	assert(std::none_of(targets.begin(), targets.end(), [](auto* t) {
+		return t == nullptr;
+	}));
 
 	Reset();
 

src/platform/sdl/sdl2_ui.cpp

@@ -1328,6 +1328,7 @@ bool Sdl2Ui::OpenURL(StringView url) {
 
 	return true;
 #else
+	(void)url;
 	Output::Warning("Cannot Open URL: SDL2 version too old (must be 2.0.14)");
 	return false;
 #endif

src/scene_battle_rpg2k3.cpp

@@ -1739,8 +1739,7 @@ Scene_Battle_Rpg2k3::SceneActionReturn Scene_Battle_Rpg2k3::ProcessSceneActionBa
 			return SceneActionReturn::eWaitTillNextFrame;
 		}
 
-		auto* battler = pending_battle_action->GetSource();
-		assert(battler != active_actor);
+		assert(pending_battle_action->GetSource() != active_actor);
 
 		pending_battle_action = {};
 		RemoveCurrentAction();