Skip to content

Commit 3fbf954

Browse files
committed
[fix] Type errors in Test scripts
1 parent 19c442c commit 3fbf954

File tree

3 files changed

+24
-15
lines changed

3 files changed

+24
-15
lines changed

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
"@parcel/packager-ts": "^2.7.0",
3030
"@parcel/transformer-typescript-types": "^2.7.0",
3131
"@types/jest": "^28.1.6",
32+
"@types/node": "^14.18.23",
3233
"husky": "^8.0.1",
3334
"jest": "^28.1.3",
3435
"lint-staged": "^13.0.3",
@@ -59,6 +60,7 @@
5960
}
6061
},
6162
"scripts": {
63+
"prepare": "husky install",
6264
"test": "lint-staged && jest --no-cache",
6365
"pack-docs": "typedoc source/",
6466
"build": "rm -rf dist/ docs/ && parcel build && npm run pack-docs",

pnpm-lock.yaml

Lines changed: 14 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/index.spec.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function createExample() {
1919
describe('Observable', () => {
2020
describe('Single', () => {
2121
const { subscriber, cleaner } = createExample();
22-
var observable: Observable;
22+
var observable: Observable<number>;
2323

2424
it('should not call Subscriber Function while constructing', () => {
2525
observable = new Observable<number>(subscriber);
@@ -28,7 +28,7 @@ describe('Observable', () => {
2828
});
2929

3030
it('should iterate Limited items asynchronously', async () => {
31-
const list = [];
31+
const list: number[] = [];
3232

3333
for await (const item of observable) list.push(item);
3434

@@ -53,7 +53,7 @@ describe('Observable', () => {
5353
describe('Pipe', () => {
5454
it('should construct an Observable from Static data', async () => {
5555
const observable = Observable.of<number>(1, 2, 3),
56-
list = [];
56+
list: number[] = [];
5757

5858
for await (const item of observable) list.push(item);
5959

@@ -73,7 +73,7 @@ describe('Observable', () => {
7373
onNext = jest.fn();
7474

7575
await new Promise<void>(resolve =>
76-
observable.subscribe(onNext, null, resolve)
76+
observable.subscribe(onNext, undefined, resolve)
7777
);
7878

7979
expect(onNext).toHaveBeenNthCalledWith(1, 1);
@@ -91,7 +91,7 @@ describe('Observable', () => {
9191
const old = new Observable<number>(subscriber);
9292

9393
const observable = Observable.from<number>(old),
94-
list = [];
94+
list: number[] = [];
9595

9696
for await (const item of observable) list.push(item);
9797

@@ -104,8 +104,8 @@ describe('Observable', () => {
104104
const target = new EventEmitter();
105105
var count = 0;
106106

107-
const observable = Observable.fromEvent(target, 'test'),
108-
list = [];
107+
const observable = Observable.fromEvent<number>(target, 'test'),
108+
list: number[] = [];
109109

110110
const timer = setInterval(() => {
111111
if (++count < 4) target.emit('test', count);
@@ -127,7 +127,7 @@ describe('Observable', () => {
127127
describe('Async Queue', () => {
128128
it('should process Data serially', async () => {
129129
const { process, destroy, observable } = createQueue(),
130-
list = [];
130+
list: number[] = [];
131131
var count = 0;
132132

133133
setTimeout(function tick() {

0 commit comments

Comments
 (0)