Fix: scripts- Incorrect <div> Tag Handling logic #12429
Open
+17
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix : This PR fixes a bug in
rtl_ltr_linter.py
where the script incorrectly processes<div>
tags.The Bug:
The lint_file function uses continue statements after detecting an opening or closing
<div>
tag. This causes the linter to stop processing the rest of the line, which leads to a problem if a single line contains both an opening and a closing tag, like<div dir="rtl">Some Text</div>.
This bug can make the
block_context_stack
inconsistent, which may result in incorrect linting of subsequent lines and lead to false positives.The Fix:
I have refactored the code to handle all
<div>
tags on a single line. Instead of using continue statements, the script now finds all<div>
tags on a line and processes them in order, ensuring theblock_context_stack
remains accurate. This fix is a minor change that improves the linter's reliability without affecting its core functionality.