Merge pull request #3842 from amvanbaren/website-improvements

website improvements

Author: amvanbaren

website/dev/main-dev.tsx

@@ -29,7 +29,7 @@ const App: FunctionComponent = () => {
         try {
          const result = await service.getRegistryVersion(abortController);
          return result.version;
-        } catch (error) {
+        } catch {
          console.error('Could not determine server version');
          return 'unknown';
         }

website/src/components/members-list.tsx

@@ -81,7 +81,6 @@ interface MemberItemProps {
     memberId?: number;
     name: string;
     logo?: string | null;
-    url?: string;
 }
 
 const bordered = (theme: Theme) => {
@@ -120,7 +119,7 @@ const GridContainer = styled(Grid)({
     textAlign: 'center',
 });
 
-const MemberItem: FunctionComponent<MemberItemProps> = ({ name, logo, url, memberId }) => {
+const MemberItem: FunctionComponent<MemberItemProps> = ({ name, logo, memberId }) => {
     const styles = {
         heading: {
             width: '100%',
@@ -139,9 +138,7 @@ const MemberItem: FunctionComponent<MemberItemProps> = ({ name, logo, url, membe
         },
     };
 
-    // Use url prop if provided, otherwise use their eclipse.org page url.
-    const websiteUrl = url || `https://www.eclipse.org/membership/showMember.php?member_id=${memberId}`;
-
+    const websiteUrl = `https://www.eclipse.org/membership/showMember.php?member_id=${memberId}`;
     return (
         <GridContainer item xs={12} md={4}>
             <HeaderBox p={2}>

website/src/main.tsx

@@ -29,7 +29,7 @@ const App: FunctionComponent = () => {
         try {
          const result = await service.getRegistryVersion(abortController);
          return result.version;
-        } catch (error) {
+        } catch {
          console.error('Could not determine server version');
          return 'unknown';
         }

website/src/page-settings.tsx

@@ -24,7 +24,7 @@ import Adopters from './adopters';
 import Members from './members';
 
 //---------- HEAD TAGS
-const HeadTags: FunctionComponent<{ title?: string, description?: string, keywords?: string, url?: string, imageUrl?: string, type?: string }> = (props) => {
+const HeadTags: FunctionComponent<{ title?: string, description?: string, keywords?: string, url?: string, imageUrl?: string }> = (props) => {
     const handleChangeClientState = (newState: any, addedTags: HelmetTags, removedTags: HelmetTags): void => {
         if (addedTags.metaTags) {
             addedTags.metaTags.forEach((value: HTMLMetaElement) => {
@@ -36,15 +36,14 @@ const HeadTags: FunctionComponent<{ title?: string, description?: string, keywor
     };
 
     const twitterCard = props.imageUrl ? 'summary_large_image' : 'summary';
-    const type = props.type || 'website';
     return <Helmet onChangeClientState={handleChangeClientState}>
         <title>{props.title}</title>
 
         {/* SEO Meta Tags */}
         <meta name='description' content={props.description} />
         <meta name='keywords' content={props.keywords} />
         <meta property='og:url' content={props.url} />
-        <meta property='og:type' content={type} />
+        <meta property='og:type' content='website' />
         <meta property='og:title' content={props.title} />
         <meta property='og:description' content={props.description} />
         <meta property='og:image' content={props.imageUrl} />
@@ -79,7 +78,7 @@ const ExtensionHeadTags: FunctionComponent<{ extension?: Extension, pageSettings
     let description: string | undefined;
     let keywords: string | undefined;
     if (props.extension) {
-        title = (props.extension.displayName || props.extension.name) + title;
+        title = (props.extension.displayName ?? props.extension.name) + title;
         url += `${props.extension.namespace}/${props.extension.name}`;
         description = props.extension.description;
         // extension description can be up to 2048 characters, truncate it.