PHPUnit 12.5 #12152

Author: PowerKiKi

.php-cs-fixer.dist.php

@@ -189,8 +189,8 @@
         'php_unit_assert_new_names' => true,
         'php_unit_attributes' => false, // Requires PHPUnit 10
         'php_unit_construct' => true,
-        'php_unit_data_provider_method_order' => true,
-        'php_unit_data_provider_name' => ['prefix' => 'provider', 'suffix' => ''],
+        'php_unit_data_provider_method_order' => false, // In most cases, yes, but we still have a few exceptions of data providers shared across multiple tests
+        'php_unit_data_provider_name' => false, // In most cases, yes, but we still have a few exceptions of data providers shared across multiple tests
         'php_unit_data_provider_return_type' => true,
         'php_unit_data_provider_static' => true,
         'php_unit_dedicate_assert' => true,

composer.json

@@ -69,6 +69,6 @@
         "mikey179/vfsstream": "@stable",
         "phpstan/phpstan": "@stable",
         "phpstan/phpstan-phpunit": "@stable",
-        "phpunit/phpunit": "^11.5"
+        "phpunit/phpunit": "@stable"
     }
 }

composer.lock

@@ -235,7 +235,7 @@ parameters:
 			path: tests/Service/ImagineFactoryTest.php
 
 		-
-			message: '#^PHPDoc tag @var with type Doctrine\\ORM\\EntityManager is not subtype of native type PHPUnit\\Framework\\MockObject\\MockObject\.$#'
+			message: '#^PHPDoc tag @var with type Doctrine\\ORM\\EntityManager is not subtype of native type PHPUnit\\Framework\\MockObject\\Stub\.$#'
 			identifier: varTag.nativeType
 			count: 1
 			path: tests/Service/MailerTest.php

phpstan-baseline.neon

@@ -35,7 +35,7 @@ public function testAssert(array $input, bool $expected): void
 
         $assertion = new All(...$assertions);
 
-        $acl = $this->createMock(Acl::class);
+        $acl = self::createStub(Acl::class);
         self::assertSame($expected, $assertion->assert($acl));
     }
 

tests/Acl/Assertion/AllTest.php

@@ -35,7 +35,7 @@ public function testAssert(array $input, bool $expected): void
 
         $assertion = new One(...$assertions);
 
-        $acl = $this->createMock(Acl::class);
+        $acl = self::createStub(Acl::class);
         self::assertSame($expected, $assertion->assert($acl));
     }
 

tests/Acl/Assertion/OneTest.php

@@ -46,7 +46,7 @@ protected function getMaximum(): ?string
         };
     }
 
-    #[DataProvider('providerInputs')]
+    #[DataProvider('providerInputs', false)]
     public function testSerialize(int $decimal, ?string $minimum, ?string $maximum, null|float|int|string $input): void
     {
         $type = $this->createType($decimal, $minimum, $maximum);

tests/Api/Scalar/AbstractDecimalTypeTest.php

@@ -16,7 +16,7 @@ abstract public function createType(): \Ecodev\Felix\Api\Scalar\AbstractStringBa
 
     abstract public function getTypeName(): string;
 
-    #[DataProvider('providerValues')]
+    #[DataProvider('providerValues', false)]
     public function testSerialize(?string $input, ?string $expected): void
     {
         $type = $this->createType();

tests/Api/Scalar/AbstractStringBasedType.php

@@ -81,7 +81,7 @@ public function testWillServeOriginalWebpIfAccepted(): void
         $image = $this->createImageMock('vfs://felix/image.webp');
         $repository = $this->createRepositoryMock($image);
 
-        $imageResizer = $this->createMock(ImageResizer::class);
+        $imageResizer = self::createStub(ImageResizer::class);
 
         // A request specifically accepting webp images
         $request = new ServerRequest();
@@ -119,7 +119,7 @@ public function testWillServeOriginalJpgIfWebpNotAccepted(): void
     public function testWillErrorIfImageNotFoundInDatabase(): void
     {
         $repository = $this->createRepositoryMock(null);
-        $imageResizer = $this->createMock(ImageResizer::class);
+        $imageResizer = self::createStub(ImageResizer::class);
         $request = new ServerRequest();
 
         $response = $this->handle($repository, $imageResizer, $request);
@@ -130,7 +130,7 @@ public function testWillErrorIfImageNotFoundOnDisk(): void
     {
         $image = $this->createImageMock('vfs://felix/totally-non-existing-path');
         $repository = $this->createRepositoryMock($image);
-        $imageResizer = $this->createMock(ImageResizer::class);
+        $imageResizer = self::createStub(ImageResizer::class);
         $request = new ServerRequest();
 
         $response = $this->handle($repository, $imageResizer, $request);

tests/Handler/ImageHandlerTest.php

@@ -27,8 +27,8 @@ public function testWithMailHandler(): void
     {
         $container = new ServiceManager([
             'factories' => [
-                DbHandler::class => fn () => $this->createMock(DbHandler::class),
-                MailerHandler::class => fn () => $this->createMock(MailerHandler::class),
+                DbHandler::class => fn () => self::createStub(DbHandler::class),
+                MailerHandler::class => fn () => self::createStub(MailerHandler::class),
             ],
         ]);
 
@@ -42,7 +42,7 @@ public function testWithoutMailHandler(): void
     {
         $container = new ServiceManager([
             'factories' => [
-                DbHandler::class => fn () => $this->createMock(DbHandler::class),
+                DbHandler::class => fn () => self::createStub(DbHandler::class),
                 MailerHandler::class => fn () => null,
             ],
         ]);