Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 0f09d14

Browse files
Adding ability to (un/)subscribe to topics at firebase #262 - iOS implementation
1 parent 6a2521b commit 0f09d14

File tree

2 files changed

+41
-4
lines changed

2 files changed

+41
-4
lines changed

firebase.android.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1493,7 +1493,7 @@ firebase.deleteFile = function (arg) {
14931493

14941494
firebase.subscribeToTopic = function(topicName){
14951495
return new Promise(function (resolve, reject) {
1496-
try{
1496+
try {
14971497

14981498
if (typeof(com.google.firebase.messaging) === "undefined") {
14991499
reject("Uncomment firebase-messaging in the plugin's include.gradle first");
@@ -1506,7 +1506,7 @@ firebase.subscribeToTopic = function(topicName){
15061506
}
15071507

15081508
com.google.firebase.messaging.FirebaseMessaging.getInstance().subscribeToTopic(topicName);
1509-
1509+
resolve();
15101510
} catch(ex){
15111511
console.log("Error in firebase.subscribeToTopic: " + ex);
15121512
reject(ex);
@@ -1516,7 +1516,7 @@ firebase.subscribeToTopic = function(topicName){
15161516

15171517
firebase.unsubscribeFromTopic = function(topicName){
15181518
return new Promise(function (resolve, reject) {
1519-
try{
1519+
try {
15201520

15211521
if (typeof(com.google.firebase.messaging) === "undefined") {
15221522
reject("Uncomment firebase-messaging in the plugin's include.gradle first");
@@ -1529,13 +1529,14 @@ firebase.unsubscribeFromTopic = function(topicName){
15291529
}
15301530

15311531
com.google.firebase.messaging.FirebaseMessaging.getInstance().unsubscribeFromTopic(topicName);
1532-
1532+
resolve();
15331533
} catch(ex){
15341534
console.log("Error in firebase.unsubscribeFromTopic: " + ex);
15351535
reject(ex);
15361536
}
15371537
});
15381538
}
1539+
15391540
/*
15401541
firebase.sendCrashLog = function (arg) {
15411542
return new Promise(function (resolve, reject) {

firebase.ios.js

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1569,6 +1569,42 @@ firebase.deleteFile = function (arg) {
15691569
});
15701570
};
15711571

1572+
firebase.subscribeToTopic = function(topicName){
1573+
return new Promise(function (resolve, reject) {
1574+
try {
1575+
1576+
if (typeof(FIRMessaging) === "undefined") {
1577+
reject("Enable FIRMessaging in Podfile first");
1578+
return;
1579+
}
1580+
1581+
FIRMessaging.messaging().subscribeToTopic(topicName);
1582+
resolve();
1583+
} catch(ex){
1584+
console.log("Error in firebase.subscribeToTopic: " + ex);
1585+
reject(ex);
1586+
}
1587+
});
1588+
};
1589+
1590+
firebase.unsubscribeFromTopic = function(topicName){
1591+
return new Promise(function (resolve, reject) {
1592+
try {
1593+
1594+
if (typeof(FIRMessaging) === "undefined") {
1595+
reject("Enable FIRMessaging in Podfile first");
1596+
return;
1597+
}
1598+
1599+
FIRMessaging.messaging().unsubscribeFromTopic(topicName);
1600+
resolve();
1601+
} catch(ex){
1602+
console.log("Error in firebase.unsubscribeFromTopic: " + ex);
1603+
reject(ex);
1604+
}
1605+
});
1606+
}
1607+
15721608
/*
15731609
firebase.sendCrashLog = function (arg) {
15741610
return new Promise(function (resolve, reject) {

0 commit comments

Comments
 (0)