Firestore: doc.exists returns true for non-existing documents #589

Author: EddyVerbruggen

CHANGELOG.md

@@ -4,7 +4,14 @@
 [Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
 
 
-## 5.1.0 & 5.1.1 (2017, December 30)
+## 5.1.1 (2017, December 30)
+
+### Fixes
+- [#589](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/589) Firestore: doc.exists returns true for non-existing documents
+- [#564](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/564) Firebase Auth + WebPack crashing iOS application (when createUser is triggered) - BETTER FIX
+
+
+## 5.1.0 (2017, December 30)
 
 ### Fixes
 - [#564](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/564) Firebase Auth + WebPack crashing iOS application (when createUser is triggered) - FIX

demo-ng/app/item/items.component.ts

@@ -147,6 +147,7 @@ export class ItemsComponent implements OnInit {
             .doc("SF")
             .collection("streets")
             .doc("QZNrg22tkN8W71YC3qCb"); // id of 'main st.'
+            // .doc("doesntexist");
 
     mainStreetInSFDocRef.get().then((doc: firestore.DocumentSnapshot) => {
       if (doc.exists) {

src/firebase.android.ts

@@ -2476,7 +2476,8 @@ firebase.firestore.getDocument = (collectionPath: string, documentPath: string):
             reject(ex && ex.getReason ? ex.getReason() : ex);
           } else {
             const result: com.google.firebase.firestore.DocumentSnapshot = task.getResult();
-            resolve(new DocumentSnapshot(result ? result.getId() : null, !!result, () => result ? firebase.toJsObject(result.getData()) : null));
+            const exists = result.exists();
+            resolve(new DocumentSnapshot(exists ? result.getId() : null, exists, () => exists ? firebase.toJsObject(result.getData()) : null));
           }
         }
       });

src/firebase.ios.ts

@@ -2457,7 +2457,8 @@ firebase.firestore.getDocument = (collectionPath: string, documentPath: string):
             if (error) {
               reject(error.localizedDescription);
             } else {
-              resolve(new DocumentSnapshot(snapshot ? snapshot.documentID : null, !!snapshot, () => snapshot ? firebase.toJsObject(snapshot.data()) : null));
+              const exists = snapshot.exists;
+              resolve(new DocumentSnapshot(exists ? snapshot.documentID : null, exists, () => exists ? firebase.toJsObject(snapshot.data()) : null));
             }
           });