Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 1d474af

Browse files
firestore.where does not work correctly with document references #888
1 parent 6977f06 commit 1d474af

File tree

5 files changed

+250
-230
lines changed

5 files changed

+250
-230
lines changed

demo-ng/app/tabs/firestore/firestore.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</ListView>
2323
<Button text="Listen to changes in SF" (tap)="firestoreListen()" class="button"></Button>
2424
<Button text="Stop listening" (tap)="firestoreStopListening()" class="button"></Button>
25-
<Button text="Where" (tap)="firestoreWhere()" class="button"></Button>
25+
<Button text="Where (by reference)" (tap)="firestoreWhere()" class="button"></Button>
2626
<Button text="Where, Order, Limit" (tap)="firestoreWhereOrderLimit()" class="button"></Button>
2727
<Button text="Where array_contains" (tap)="firestoreWhereCityHasALake()" class="button"></Button>
2828
<Button text="Start at 'LA'" (tap)="firestoreStartAt()" class="button"></Button>

demo-ng/app/tabs/firestore/firestore.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -247,11 +247,10 @@ export class FirestoreComponent {
247247
}
248248

249249
public firestoreWhere(): void {
250-
const query: firestore.Query = firebase.firestore().collection("cities")
251-
.where("state", "==", "CA")
252-
.where("population", "<", 550000);
250+
const cityDocRef = firebase.firestore().collection("cities").doc("SF");
253251

254-
query
252+
firebase.firestore().collection("dogs")
253+
.where("city", "==", cityDocRef)
255254
.get()
256255
.then((querySnapshot: firestore.QuerySnapshot) => {
257256
querySnapshot.forEach(doc => {
@@ -264,6 +263,7 @@ export class FirestoreComponent {
264263
public firestoreWhereOrderLimit(): void {
265264
const query: firestore.Query = firebase.firestore().collection("cities")
266265
.where("state", "==", "CA")
266+
.where("population", "<", 99999999)
267267
.orderBy("population", "desc")
268268
.limit(2);
269269

demo-ng/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"nativescript-angular": "^6.1.0",
2626
"nativescript-camera": "^4.0.2",
2727
"nativescript-imagepicker": "^6.0.1",
28-
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-6.5.0.tgz",
28+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-6.6.0.tgz",
2929
"nativescript-theme-core": "~1.0.4",
3030
"reflect-metadata": "~0.1.10",
3131
"rxjs": "~6.0.0 || >=6.1.0",

0 commit comments

Comments
 (0)