No error thrown when write fails #455

Author: EddyVerbruggen

CHANGELOG.md

@@ -3,7 +3,7 @@
 [Firebase iOS SDK Changelog](https://firebase.google.com/support/release-notes/ios)
 [Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
 
-## 6.4.1 (2018, July 13)
+## 6.4.1 (2018, July 23)
 [Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/64?closed=1)
 
 

src/firebase.android.ts

@@ -1703,10 +1703,14 @@ firebase.push = (path, val) => {
       }
 
       const pushInstance = firebase.instance.child(path).push();
-      pushInstance.setValue(firebase.toValue(val));
-      resolve({
-        key: pushInstance.getKey()
+
+      const onCompletionListener = new com.google.firebase.database.DatabaseReference.CompletionListener({
+        onComplete: (error: any /* com.google.firebase.database.DatabaseError */, dbRef: any /* com.google.firebase.database.DatabaseReference */) => {
+          error ? reject(error.getMessage()) : resolve({ key: pushInstance.getKey() });
+        }
       });
+
+      pushInstance.setValue(firebase.toValue(val), onCompletionListener);
     } catch (ex) {
       console.log("Error in firebase.push: " + ex);
       reject(ex);
@@ -1722,8 +1726,13 @@ firebase.setValue = (path, val) => {
         return;
       }
 
-      firebase.instance.child(path).setValue(firebase.toValue(val));
-      resolve();
+      const onCompletionListener = new com.google.firebase.database.DatabaseReference.CompletionListener({
+        onComplete: (error: any /* com.google.firebase.database.DatabaseError */, dbRef: any /* com.google.firebase.database.DatabaseReference */) => {
+          error ? reject(error.getMessage()) : resolve();
+        }
+      });
+
+      firebase.instance.child(path).setValue(firebase.toValue(val), onCompletionListener);
     } catch (ex) {
       console.log("Error in firebase.setValue: " + ex);
       reject(ex);
@@ -1739,16 +1748,21 @@ firebase.update = (path, val) => {
         return;
       }
 
+      const onCompletionListener = new com.google.firebase.database.DatabaseReference.CompletionListener({
+        onComplete: (error: any /* com.google.firebase.database.DatabaseError */, dbRef: any /* com.google.firebase.database.DatabaseReference */) => {
+          error ? reject(error.getMessage()) : resolve();
+        }
+      });
+
       if (typeof val === "object") {
-        firebase.instance.child(path).updateChildren(firebase.toHashMap(val));
+        firebase.instance.child(path).updateChildren(firebase.toHashMap(val), onCompletionListener);
       } else {
         const lastPartOfPath = path.lastIndexOf("/");
         const pathPrefix = path.substring(0, lastPartOfPath);
         const pathSuffix = path.substring(lastPartOfPath + 1);
         const updateObject = '{"' + pathSuffix + '" : "' + val + '"}';
-        firebase.instance.child(pathPrefix).updateChildren(firebase.toHashMap(JSON.parse(updateObject)));
+        firebase.instance.child(pathPrefix).updateChildren(firebase.toHashMap(JSON.parse(updateObject)), onCompletionListener);
       }
-      resolve();
     } catch (ex) {
       console.log("Error in firebase.update: " + ex);
       reject(ex);
@@ -1879,8 +1893,14 @@ firebase.remove = path => {
         reject("Run init() first!");
         return;
       }
-      firebase.instance.child(path).setValue(null);
-      resolve();
+
+      const onCompletionListener = new com.google.firebase.database.DatabaseReference.CompletionListener({
+        onComplete: (error: any /* com.google.firebase.database.DatabaseError */, dbRef: any /* com.google.firebase.database.DatabaseReference */) => {
+          error ? reject(error.getMessage()) : resolve();
+        }
+      });
+
+      firebase.instance.child(path).setValue(null, onCompletionListener);
     } catch (ex) {
       console.log("Error in firebase.remove: " + ex);
       reject(ex);

src/firebase.ios.ts

@@ -1777,9 +1777,8 @@ firebase.push = (path, val) => {
   return new Promise((resolve, reject) => {
     try {
       const ref = FIRDatabase.database().reference().childByAppendingPath(path).childByAutoId();
-      ref.setValue(val);
-      resolve({
-        key: ref.key
+      ref.setValueWithCompletionBlock(val, (error: NSError, dbRef: FIRDatabaseReference) => {
+        error ? reject(error.localizedDescription) : resolve({ key: ref.key });
       });
     } catch (ex) {
       console.log("Error in firebase.push: " + ex);
@@ -1791,8 +1790,9 @@ firebase.push = (path, val) => {
 firebase.setValue = (path, val) => {
   return new Promise((resolve, reject) => {
     try {
-      FIRDatabase.database().reference().childByAppendingPath(path).setValue(val);
-      resolve();
+      FIRDatabase.database().reference().childByAppendingPath(path).setValueWithCompletionBlock(val, (error: NSError, dbRef: FIRDatabaseReference) => {
+        error ? reject(error.localizedDescription) : resolve();
+      });
     } catch (ex) {
       console.log("Error in firebase.setValue: " + ex);
       reject(ex);
@@ -1804,16 +1804,18 @@ firebase.update = (path, val) => {
   return new Promise((resolve, reject) => {
     try {
       if (typeof val === "object") {
-        FIRDatabase.database().reference().childByAppendingPath(path).updateChildValues(val);
+        FIRDatabase.database().reference().childByAppendingPath(path).updateChildValuesWithCompletionBlock(val, (error: NSError, dbRef: FIRDatabaseReference) => {
+          error ? reject(error.localizedDescription) : resolve();
+        });
       } else {
         const lastPartOfPath = path.lastIndexOf("/");
         const pathPrefix = path.substring(0, lastPartOfPath);
         const pathSuffix = path.substring(lastPartOfPath + 1);
         const updateObject = '{"' + pathSuffix + '" : "' + val + '"}';
-        FIRDatabase.database().reference().childByAppendingPath(pathPrefix).updateChildValues(JSON.parse(updateObject));
+        FIRDatabase.database().reference().childByAppendingPath(pathPrefix).updateChildValuesWithCompletionBlock(JSON.parse(updateObject), (error: NSError, dbRef: FIRDatabaseReference) => {
+          error ? reject(error.localizedDescription) : resolve();
+        });
       }
-
-      resolve();
     } catch (ex) {
       console.log("Error in firebase.update: " + ex);
       reject(ex);
@@ -1923,8 +1925,9 @@ firebase.query = (updateCallback, path, options) => {
 firebase.remove = path => {
   return new Promise((resolve, reject) => {
     try {
-      FIRDatabase.database().reference().childByAppendingPath(path).setValue(null);
-      resolve();
+      FIRDatabase.database().reference().childByAppendingPath(path).setValueWithCompletionBlock(null, (error: NSError, dbRef: FIRDatabaseReference) => {
+        error ? reject(error.localizedDescription) : resolve();
+      });
     } catch (ex) {
       console.log("Error in firebase.remove: " + ex);
       reject(ex);