Admob RangeError: Maximum call stack size exceeded. #813

Author: EddyVerbruggen

demo/app/main-view-model.ts

@@ -534,8 +534,8 @@ export class HelloWorldModel extends Observable {
       testing: true,
       // Android automatically adds the connected device as test device with testing:true, iOS does not
       iosTestDeviceIds: [
-        "45d77bf513dfabc2949ba053da83c0c7b7e87715", // Eddy's iPhone 6s
-        "fee4cf319a242eab4701543e4c16db89c722731f"  // Eddy's iPad Pro
+        "fee4cf319a242eab4701543e4c16db89c722731f",  // Eddy's iPad Pro
+        "a4cbb499e279054b55c206528f8510ff7fbf20c8",  // Eddy's iPhone X
       ],
       keywords: ["keyword1", "keyword2"] // add keywords for ad targeting
     }).then(

src/firebase.ios.ts

@@ -506,11 +506,6 @@ firebase.admob.showBanner = arg => {
 
       view.addSubview(firebase.admob.adView);
 
-      // support rotation events
-      // tear down first if this had been called already to avoid multiple event bindings
-      application.off(application.orientationChangedEvent, firebase.admob.orientationHandler);
-      application.on(application.orientationChangedEvent, firebase.admob.orientationHandler);
-
       resolve();
     } catch (ex) {
       console.log("Error in firebase.admob.showBanner: " + ex);
@@ -519,20 +514,6 @@ firebase.admob.showBanner = arg => {
   });
 };
 
-firebase.admob.orientationHandler = data => {
-  if (firebase.admob.adView !== null) {
-    firebase.admob.hideBanner().then(res => {
-      try {
-        firebase.admob.showBanner(firebase.admob.bannerOptions || firebase.admob.defaults);
-      } catch (err) {
-        console.log("Error in orientationHandler - firebase.admob.showBanner: " + err);
-      }
-    }, err => {
-      console.log("Error in orientationHandler - firebase.admob.hideBanner: " + err);
-    });
-  }
-};
-
 firebase.admob.showInterstitial = arg => {
   return new Promise((resolve, reject) => {
     try {