TODO's handled

Author: EddyVerbruggen

src/firebase.ios.ts

@@ -875,7 +875,7 @@ firebase.admob.showInterstitial = arg => {
       // with interstitials you MUST wait for the ad to load before showing it, so requiring this delegate
       let delegate = GADInterstitialDelegateImpl.new().initWithCallback((ad: GADInterstitial, error: GADRequestError) => {
         if (error) {
-          reject(error); // TODO this is a platform-specific type
+          reject(error.localizedDescription);
         } else {
           // now we can safely show it
           firebase.admob.interstitialView.presentFromRootViewController(utils.ios.getter(UIApplication, UIApplication.sharedApplication).keyWindow.rootViewController);
@@ -1267,6 +1267,7 @@ firebase.login = arg => {
           return;
         }
 
+
         // TODO does this still work (there's a delegate now which we're not implementing)?
         FIRPhoneAuthProvider.provider().verifyPhoneNumberUIDelegateCompletion(arg.phoneOptions.phoneNumber, null, (verificationID: string, error: NSError) => {
           if (error) {
@@ -2686,6 +2687,7 @@ class FIRMessagingDelegateImpl extends NSObject implements FIRMessagingDelegate
     return this;
   }
 
+
   // TODO test that receiving push notifications in the foreground still works
   public messagingDidReceiveMessage(messaging: FIRMessaging, remoteMessage: FIRMessagingRemoteMessage): void {
     console.log(">> fcm message received");

src/mlkit/barcodescanning/index.ios.ts

@@ -90,7 +90,6 @@ export function scanBarcodesOnDevice(options: MLKitScanBarcodesOnDeviceOptions):
   });
 }
 
-// TODO move
 function getImage(options: MLKitOptions): FIRVisionImage {
   const image: UIImage = options.image instanceof ImageSource ? options.image.ios : options.image.imageSource.ios;
   return FIRVisionImage.alloc().initWithImage(image);

src/mlkit/facedetection/index.android.ts

@@ -101,7 +101,6 @@ export function detectFacesOnDevice(options: MLKitDetectFacesOnDeviceOptions): P
   });
 }
 
-// TODO move up
 function getImage(options: MLKitOptions): any /* com.google.firebase.ml.vision.common.FirebaseVisionImage */ {
   const image: android.graphics.Bitmap = options.image instanceof ImageSource ? options.image.android : options.image.imageSource.android;
   return com.google.firebase.ml.vision.common.FirebaseVisionImage.fromBitmap(image);

src/mlkit/facedetection/index.ios.ts

@@ -45,7 +45,7 @@ export class MLKitFaceDetection extends MLKitFaceDetectionBase {
 }
 
 function getDetector(): FIRVisionFaceDetector {
-  // TODO make configurable
+  // TODO make configurable (see #704)
   const firVision: FIRVision = FIRVision.vision();
   const options = FIRVisionFaceDetectorOptions.new();
   options.modeType = FIRVisionFaceDetectorMode.Accurate;

src/mlkit/landmarkrecognition/index.d.ts

@@ -1,7 +1,7 @@
 import { MLKitCloudOptions, MLKitResult } from "../index";
 
 export interface MLKitLandmarkRecognitionCloudResult extends MLKitResult {
-  // TODO add locations
+  // TODO add locations (see #704)
   landmarks: Array<{
     name: string;
     confidence: number;

src/mlkit/textrecognition/index.ios.ts

@@ -120,7 +120,6 @@ export function recognizeTextCloud(options: MLKitRecognizeTextCloudOptions): Pro
   });
 }
 
-// TODO move to a common file
 function getImage(options: MLKitOptions): FIRVisionImage {
   const image: UIImage = options.image instanceof ImageSource ? options.image.ios : options.image.imageSource.ios;
   return FIRVisionImage.alloc().initWithImage(image);