Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 39f5df6

Browse files
Bump Firebase SDK versions #590
1 parent 1aac210 commit 39f5df6

File tree

9 files changed

+47
-25
lines changed

9 files changed

+47
-25
lines changed

CHANGELOG.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,15 @@
44
[Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
55

66

7+
## 5.1.0 (2017, December 30)
8+
9+
### Fixes
10+
- [#564](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/564) Firebase Auth + WebPack crashing iOS application (when createUser is triggered) - FIX
11+
12+
### New
13+
- [#590](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/590) Bump Firebase SDK versions
14+
15+
716
## 5.0.5 (2017, December 19)
817

918
### Fixes

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,9 @@ android {
228228
// other stuff here
229229
230230
project.ext {
231-
googlePlayServicesVersion = "11.4.2"
231+
googlePlayServicesVersion = "11.8.0"
232232
}
233233
}
234234
```
235235

236-
Where `"11.4.2"` is best set to the same value as the `firebaseVersion` value in [this file](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/blob/master/src/platforms/android/include.gradle).
236+
Where `"11.8.0"` is best set to the same value as the `firebaseVersion` value in [this file](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/blob/master/src/platforms/android/include.gradle).

demo/app/main-view-model.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ export class HelloWorldModel extends Observable {
258258
setTimeout(() => {
259259
alert({
260260
title: "Push message!",
261-
message: (message.title !== undefined ? message.title : "") + (message.data ? " Data: " + JSON.stringify(message.data) : ""),
261+
message: (message.title !== undefined ? message.title : ""),
262262
okButtonText: "Sw33t"
263263
});
264264
}, 500);
@@ -456,7 +456,6 @@ export class HelloWorldModel extends Observable {
456456
);
457457
firebase.addOnMessageReceivedCallback(
458458
message => {
459-
console.log("----- message received: " + JSON.stringify(message));
460459
alert({
461460
title: "Push message!",
462461
message: (message.title !== undefined ? message.title : ""),

demo/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,17 @@
22
"nativescript": {
33
"id": "org.nativescript.firebasedemo",
44
"tns-ios": {
5-
"version": "3.3.0"
5+
"version": "3.4.0"
66
},
77
"tns-android": {
8-
"version": "3.3.1"
8+
"version": "3.4.0"
99
}
1010
},
1111
"dependencies": {
12-
"nativescript-plugin-firebase": "file:../src",
12+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-5.1.0.tgz",
1313
"nativescript-theme-core": "^1.0.4",
1414
"nativescript-unit-test-runner": "^0.3.4",
15-
"tns-core-modules": "^3.3.0"
15+
"tns-core-modules": "~3.4.0"
1616
},
1717
"devDependencies": {
1818
"@types/jasmine": "^2.6.3",
@@ -33,7 +33,7 @@
3333
"nativescript-dev-webpack": "^0.7.3",
3434
"raw-loader": "~0.5.1",
3535
"resolve-url-loader": "~2.1.0",
36-
"tns-platform-declarations": "^3.2.0",
36+
"tns-platform-declarations": "~3.4.0",
3737
"tslint": "~5.4.3",
3838
"typescript": "~2.4.0",
3939
"webpack": "~3.2.0",

publish/scripts/installer.js

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@ function writePodFile(result) {
223223
}
224224
try {
225225
fs.writeFileSync(directories.ios + '/Podfile',
226-
`pod 'Firebase', '~> 4.6.0'
226+
`pod 'Firebase', '~> 4.8.0'
227227
pod 'Firebase/Auth'
228228
229229
# Uncomment if you want to enable Realtime DB
@@ -300,7 +300,7 @@ dependencies {
300300
compile "com.android.support:design:$supportVersion"
301301
compile "com.android.support:support-compat:$supportVersion"
302302
303-
def firebaseVersion = "11.4.2"
303+
def firebaseVersion = "11.8.0"
304304
305305
// make sure you have these versions by updating your local Android SDK's (Android Support repo and Google repo)
306306
compile "com.google.firebase:firebase-core:$firebaseVersion"
@@ -405,14 +405,21 @@ module.exports = function() {
405405
if (fs.existsSync(buildGradlePath)) {
406406
var buildGradleContent = fs.readFileSync(buildGradlePath).toString();
407407
408-
// already at 3.1.0?
408+
// already at 3.1.1?
409+
if (buildGradleContent.indexOf('classpath "com.google.gms:google-services:3.1.1"') != -1) {
410+
return;
411+
}
412+
413+
// upgrade 3.1.0 to 3.1.1?
409414
if (buildGradleContent.indexOf('classpath "com.google.gms:google-services:3.1.0"') != -1) {
415+
buildGradleContent = buildGradleContent.replace('classpath "com.google.gms:google-services:3.1.0"', 'classpath "com.google.gms:google-services:3.1.1"');
416+
fs.writeFileSync(buildGradlePath, buildGradleContent);
410417
return;
411418
}
412419
413-
// upgrade 3.0.0 to 3.1.0?
420+
// upgrade 3.0.0 to 3.1.1?
414421
if (buildGradleContent.indexOf('classpath "com.google.gms:google-services:3.0.0"') != -1) {
415-
buildGradleContent = buildGradleContent.replace('classpath "com.google.gms:google-services:3.0.0"', 'classpath "com.google.gms:google-services:3.1.0"');
422+
buildGradleContent = buildGradleContent.replace('classpath "com.google.gms:google-services:3.0.0"', 'classpath "com.google.gms:google-services:3.1.1"');
416423
fs.writeFileSync(buildGradlePath, buildGradleContent);
417424
return;
418425
}
@@ -434,7 +441,7 @@ module.exports = function() {
434441
return;
435442
}
436443
437-
buildGradleContent = buildGradleContent.substr(0, search - 1) + ' classpath "com.google.gms:google-services:3.1.0"\\n ' + buildGradleContent.substr(search - 1);
444+
buildGradleContent = buildGradleContent.substr(0, search - 1) + ' classpath "com.google.gms:google-services:3.1.1"\\n ' + buildGradleContent.substr(search - 1);
438445
439446
fs.writeFileSync(buildGradlePath, buildGradleContent);
440447
}

src/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-plugin-firebase",
3-
"version": "5.0.5",
3+
"version": "5.1.0",
44
"description": "Fire. Base. Firebase!",
55
"main": "firebase",
66
"typings": "index.d.ts",
@@ -40,8 +40,8 @@
4040
"plugin.tscwatch": "npm run tsc -- -w",
4141
"package": "cd ../publish && rm -rf ./package && ./pack.sh",
4242
"demo.ios": "npm run preparedemo && cd ../demo && tns run ios --emulator",
43-
"demo-ng.ios": "npm run preparedemo-ng && cd ../demo-ng && tns run ios --emulator",
4443
"demo.ios.device": "npm run preparedemo && cd ../demo && tns platform remove ios && tns run ios",
44+
"demo-ng.ios": "npm run preparedemo-ng && cd ../demo-ng && tns run ios --emulator",
4545
"demo-ng.ios.device": "npm run preparedemo-ng && cd ../demo-ng && tns platform remove ios && tns run ios",
4646
"demo.android": "npm run preparedemo && cd ../demo && tns platform remove android && tns run android --justlaunch",
4747
"demo-ng.android": "npm run preparedemo-ng && cd ../demo-ng && tns platform remove android && tns run android --justlaunch",

src/platforms/android/include.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ dependencies {
2424
compile "com.android.support:design:$supportVersion"
2525
compile "com.android.support:support-compat:$supportVersion"
2626

27-
def firebaseVersion = "11.4.2"
27+
def firebaseVersion = "11.8.0"
2828

2929
// make sure you have these versions by updating your local Android SDK's (Android Support repo and Google repo)
3030
compile "com.google.firebase:firebase-core:$firebaseVersion"

src/platforms/ios/Podfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
pod 'Firebase', '~> 4.6.0'
1+
pod 'Firebase', '~> 4.8.0'
22
pod 'Firebase/Auth'
33

44
# Uncomment if you want to enable the regular Database (instead of Cloud Firestore)

src/scripts/postinstall.js

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3021,7 +3021,7 @@ function writePodFile(result) {
30213021
}
30223022
try {
30233023
fs.writeFileSync(directories.ios + '/Podfile',
3024-
`pod 'Firebase', '~> 4.6.0'
3024+
`pod 'Firebase', '~> 4.8.0'
30253025
pod 'Firebase/Auth'
30263026
30273027
# Uncomment if you want to enable Realtime DB
@@ -3098,7 +3098,7 @@ dependencies {
30983098
compile "com.android.support:design:$supportVersion"
30993099
compile "com.android.support:support-compat:$supportVersion"
31003100
3101-
def firebaseVersion = "11.4.2"
3101+
def firebaseVersion = "11.8.0"
31023102
31033103
// make sure you have these versions by updating your local Android SDK's (Android Support repo and Google repo)
31043104
compile "com.google.firebase:firebase-core:$firebaseVersion"
@@ -3203,14 +3203,21 @@ module.exports = function() {
32033203
if (fs.existsSync(buildGradlePath)) {
32043204
var buildGradleContent = fs.readFileSync(buildGradlePath).toString();
32053205
3206-
// already at 3.1.0?
3206+
// already at 3.1.1?
3207+
if (buildGradleContent.indexOf('classpath "com.google.gms:google-services:3.1.1"') != -1) {
3208+
return;
3209+
}
3210+
3211+
// upgrade 3.1.0 to 3.1.1?
32073212
if (buildGradleContent.indexOf('classpath "com.google.gms:google-services:3.1.0"') != -1) {
3213+
buildGradleContent = buildGradleContent.replace('classpath "com.google.gms:google-services:3.1.0"', 'classpath "com.google.gms:google-services:3.1.1"');
3214+
fs.writeFileSync(buildGradlePath, buildGradleContent);
32083215
return;
32093216
}
32103217
3211-
// upgrade 3.0.0 to 3.1.0?
3218+
// upgrade 3.0.0 to 3.1.1?
32123219
if (buildGradleContent.indexOf('classpath "com.google.gms:google-services:3.0.0"') != -1) {
3213-
buildGradleContent = buildGradleContent.replace('classpath "com.google.gms:google-services:3.0.0"', 'classpath "com.google.gms:google-services:3.1.0"');
3220+
buildGradleContent = buildGradleContent.replace('classpath "com.google.gms:google-services:3.0.0"', 'classpath "com.google.gms:google-services:3.1.1"');
32143221
fs.writeFileSync(buildGradlePath, buildGradleContent);
32153222
return;
32163223
}
@@ -3232,7 +3239,7 @@ module.exports = function() {
32323239
return;
32333240
}
32343241
3235-
buildGradleContent = buildGradleContent.substr(0, search - 1) + ' classpath "com.google.gms:google-services:3.1.0"\\n ' + buildGradleContent.substr(search - 1);
3242+
buildGradleContent = buildGradleContent.substr(0, search - 1) + ' classpath "com.google.gms:google-services:3.1.1"\\n ' + buildGradleContent.substr(search - 1);
32363243
32373244
fs.writeFileSync(buildGradlePath, buildGradleContent);
32383245
}

0 commit comments

Comments
 (0)