Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 3f64388

Browse files
Add support for AdMob's "Rewarded Video Ads" #1085
1 parent e07c53a commit 3f64388

File tree

2 files changed

+5
-21
lines changed

2 files changed

+5
-21
lines changed

docs/ADMOB.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,10 @@ Open `app/App_Resources/iOS/Info.plist` and add this to the bottom:
4040
[More info on this subject.](https://firebase.google.com/docs/admob/ios/app-transport-security)
4141

4242
## Functions
43+
> Note that it may take up to 24 hours after adding an Ad to your [AdMob console](https://apps.admob.com) before it's available for your app. Until then you'll see a ⚠️ warning about an unknown Ad ID.
4344
4445
### admob.showBanner
45-
Go [manage your AdMob app](https://apps.admob.com/#account/appmgmt:) and grab the banner, then show it in your app:
46+
Go [manage your AdMob app](https://apps.admob.com) and grab the banner, then show it in your app:
4647

4748
```js
4849
firebase.admob.showBanner({

src/admob/admob.android.ts

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ export function showBanner(arg: BannerOptions): Promise<any> {
1313
return new Promise((resolve, reject) => {
1414
try {
1515
const settings = firebase.merge(arg, BANNER_DEFAULTS);
16-
console.log({settings});
1716

1817
// always close a previously opened banner
1918
if (firebase.admob.adView !== null && firebase.admob.adView !== undefined) {
@@ -39,7 +38,6 @@ export function showBanner(arg: BannerOptions): Promise<any> {
3938
this.resolve();
4039
},
4140
onAdFailedToLoad: errorCode => {
42-
// console.log('ad error: ' + errorCode);
4341
this.reject(errorCode);
4442
}
4543
});
@@ -180,55 +178,41 @@ export function preloadRewardedVideoAd(arg: PreloadRewardedVideoAdOptions): Prom
180178
const settings = firebase.merge(arg, BANNER_DEFAULTS);
181179
const activity = appModule.android.foregroundActivity || appModule.android.startActivity;
182180
firebase.admob.rewardedAdVideoView = com.google.android.gms.ads.MobileAds.getRewardedVideoAdInstance(activity);
183-
console.log("firebase.admob.rewardedAdVideoView " + firebase.admob.rewardedAdVideoView);
184181

185182
rewardedVideoCallbacks.onLoaded = resolve;
186183
rewardedVideoCallbacks.onFailedToLoad = reject;
187184

188185
// rewarded Ads must be loaded before they can be shown, so adding a listener
189-
190-
console.log("com.google.android.gms.ads.AdListener: " + com.google.android.gms.ads.AdListener);
191-
192186
const RewardedVideoAdListener = com.google.android.gms.ads.reward.RewardedVideoAdListener.extend({
193187
onRewarded(reward) {
194-
console.log("reward1: " + reward);
195-
console.log("reward2: " + reward.toString());
196-
console.log("reward3: " + JSON.stringify(reward));
197-
rewardedVideoCallbacks.onRewarded({ // TODO
198-
amount: 1,
199-
type: "TODO"
188+
rewardedVideoCallbacks.onRewarded({
189+
amount: reward.getAmount(),
190+
type: reward.getType()
200191
});
201192
},
202193
onRewardedVideoAdLeftApplication() {
203-
console.log("onRewardedVideoAdLeftApplication");
204194
rewardedVideoCallbacks.onLeftApplication();
205195
},
206196
onRewardedVideoAdClosed() {
207-
console.log("onRewardedVideoAdClosed");
208197
if (firebase.admob.rewardedAdVideoView) {
209198
firebase.admob.rewardedAdVideoView.setRewardedVideoAdListener(null);
210199
firebase.admob.rewardedAdVideoView = null;
211200
}
212201
rewardedVideoCallbacks.onClosed();
213202
},
214203
onRewardedVideoAdFailedToLoad(errorCode) {
215-
console.log("onRewardedVideoAdFailedToLoad, errorCode: " + errorCode);
216204
rewardedVideoCallbacks.onFailedToLoad(errorCode);
217205
},
218206
onRewardedVideoAdLoaded() {
219-
console.log("onRewardedVideoAdLoaded");
220207
rewardedVideoCallbacks.onLoaded();
221208
},
222209
onRewardedVideoAdOpened() {
223-
console.log("onRewardedVideoAdOpened");
224210
rewardedVideoCallbacks.onOpened();
225211
},
226212
onRewardedVideoStarted() {
227-
console.log("onRewardedVideoStarted");
228213
rewardedVideoCallbacks.onStarted();
229214
},
230215
onRewardedVideoCompleted() {
231-
console.log("onRewardedVideoCompleted");
232216
rewardedVideoCallbacks.onCompleted();
233217
}
234218
});
@@ -304,7 +288,6 @@ export function hideBanner(): Promise<any> {
304288
}
305289

306290
function _getBannerType(size): any {
307-
console.log(">> _getBannerType: " + size);
308291
if (size === AD_SIZE.BANNER) {
309292
return com.google.android.gms.ads.AdSize.BANNER;
310293
} else if (size === AD_SIZE.LARGE_BANNER) {

0 commit comments

Comments
 (0)