Analytics collection was incorrectly disabled by default since 6.7.0 #915

Author: EddyVerbruggen

demo/app/main-view-model.ts

@@ -377,7 +377,7 @@ export class HelloWorldModel extends Observable {
     firebase.init({
       // storageBucket: 'gs://n-plugin-test.appspot.com',
       persist: true, // optional, default false
-      analyticsCollectionEnabled: true,
+      // analyticsCollectionEnabled: false, // default true
       onAuthStateChanged: data => { // optional
         console.log((data.loggedIn ? "Logged in to firebase" : "Logged out from firebase") + " (init's onAuthStateChanged callback)");
         if (data.loggedIn) {
@@ -451,11 +451,11 @@ export class HelloWorldModel extends Observable {
       key: "add_to_cart",
       parameters: [{ // optional
         key: "item_id",
-        value: "p7654"
+        value: "p7655"
       },
       {
         key: "item_name",
-        value: "abc"
+        value: "abcd"
       }]
     }).then(
       () => {

src/firebase.android.ts

@@ -269,7 +269,7 @@ firebase.init = arg => {
 
       com.google.firebase.analytics.FirebaseAnalytics.getInstance(
           appModule.android.currentContext || com.tns.NativeScriptApplication.getInstance()
-      ).setAnalyticsCollectionEnabled(arg.analyticsCollectionEnabled || false);
+      ).setAnalyticsCollectionEnabled(arg.analyticsCollectionEnabled !== false);
 
       if (typeof (com.google.firebase.database) !== "undefined" && typeof (com.google.firebase.database.ServerValue) !== "undefined") {
         firebase.ServerValue = {

src/firebase.ios.ts

@@ -354,7 +354,7 @@ firebase.init = arg => {
         FIROptions.defaultOptions().deepLinkURLScheme = iOSUtils.getter(NSBundle, NSBundle.mainBundle).bundleIdentifier;
       }
 
-      FIRAnalyticsConfiguration.sharedInstance().setAnalyticsCollectionEnabled(arg.analyticsCollectionEnabled || false);
+      FIRAnalyticsConfiguration.sharedInstance().setAnalyticsCollectionEnabled(arg.analyticsCollectionEnabled !== false);
 
       if (!firebase._configured) {
         firebase._configured = true;