Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 410805a

Browse files
RawValue is the only value returned by Barcode scan #1506
1 parent 5e3dded commit 410805a

File tree

9 files changed

+14
-5
lines changed

9 files changed

+14
-5
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
- [Firebase iOS SDK Changelog](https://firebase.google.com/support/release-notes/ios)
44
- [Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
55

6+
## 10.3.1 (2019, Dec ?)
7+
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/119?closed=1)
8+
9+
610
## 10.3.0 (2019, Dec 2)
711
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/118?closed=1)
812

demo-ng/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"nativescript-angular": "~8.0.3",
2626
"nativescript-camera": "~4.5.0",
2727
"nativescript-imagepicker": "~6.2.0",
28-
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.0.tgz",
28+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.1.tgz",
2929
"nativescript-theme-core": "~1.0.6",
3030
"reflect-metadata": "~0.1.13",
3131
"rxjs": "~6.5.2",

demo-push/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
}
1010
},
1111
"dependencies": {
12-
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.0.tgz",
12+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.1.tgz",
1313
"nativescript-theme-core": "~1.0.6",
1414
"nativescript-unit-test-runner": "0.7.0",
1515
"tns-core-modules": "~6.1.1"

demo-vue/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
}
1515
},
1616
"dependencies": {
17-
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.0.tgz",
17+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.1.tgz",
1818
"nativescript-theme-core": "~1.0.6",
1919
"nativescript-vue": "~2.4.0",
2020
"tns-core-modules": "~6.1.1"

demo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
},
1111
"dependencies": {
1212
"firebase-functions": "^2.0.5",
13-
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.0.tgz",
13+
"nativescript-plugin-firebase": "file:../publish/package/nativescript-plugin-firebase-10.3.1.tgz",
1414
"nativescript-theme-core": "^1.0.4",
1515
"nativescript-unit-test-runner": "0.7.0",
1616
"tns-core-modules": "~6.1.1"

src/mlkit/barcodescanning/index.android.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@ export class MLKitBarcodeScanner extends MLKitBarcodeScannerBase {
7676
const barcode = barcodes.get(i);
7777
result.barcodes.push({
7878
value: barcode.getRawValue(),
79+
displayValue: barcode.getDisplayValue(),
7980
format: BarcodeFormat[barcode.getFormat()],
8081
android: barcode,
8182
bounds: boundingBoxToBounds(barcode.getBoundingBox()),
@@ -154,6 +155,7 @@ export function scanBarcodesOnDevice(options: MLKitScanBarcodesOnDeviceOptions):
154155
const barcode = barcodes.get(i);
155156
result.barcodes.push({
156157
value: barcode.getRawValue(),
158+
displayValue: barcode.getDisplayValue(),
157159
format: BarcodeFormat[barcode.getFormat()],
158160
android: barcode,
159161
bounds: boundingBoxToBounds(barcode.getBoundingBox()),

src/mlkit/barcodescanning/index.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ export interface MLKitScanBarcodesResultBounds {
1616

1717
export interface MLKitScanBarcodesResultBarcode {
1818
value: string;
19+
displayValue: string;
1920
format: string;
2021
bounds: MLKitScanBarcodesResultBounds;
2122
image: {

src/mlkit/barcodescanning/index.ios.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,7 @@ export class MLKitBarcodeScanner extends MLKitBarcodeScannerBase {
7777

7878
result.barcodes.push({
7979
value: barcode.rawValue,
80+
displayValue: barcode.displayValue,
8081
format: BarcodeFormat[barcode.format],
8182
ios: barcode,
8283
bounds: {
@@ -159,6 +160,7 @@ export function scanBarcodesOnDevice(options: MLKitScanBarcodesOnDeviceOptions):
159160
const barcode: FIRVisionBarcode = barcodes.objectAtIndex(i);
160161
result.barcodes.push({
161162
value: barcode.rawValue,
163+
displayValue: barcode.displayValue,
162164
format: BarcodeFormat[barcode.format],
163165
ios: barcode,
164166
bounds: barcode.frame,

src/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-plugin-firebase",
3-
"version": "10.3.0",
3+
"version": "10.3.1",
44
"description": "Fire. Base. Firebase!",
55
"main": "firebase",
66
"typings": "index.d.ts",

0 commit comments

Comments
 (0)