Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 50732ab

Browse files
authored
Android Apple Sign-In promise is never resolved
Apple Sign-In promise gets never resolved, because the success listener is missing a resolve call.
1 parent f045306 commit 50732ab

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/firebase.android.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1068,10 +1068,12 @@ firebase.login = arg => {
10681068
const onSuccessListener = new gmsTasks.OnSuccessListener({
10691069
onSuccess: (authResult: com.google.firebase.auth.AuthResult) => {
10701070
firebase._appleSignInIdToken = (<any>authResult.getCredential()).getIdToken();
1071+
const loginResult = toLoginResult(authResult.getUser(), authResult.getAdditionalUserInfo());
10711072
firebase.notifyAuthStateListeners({
10721073
loggedIn: true,
1073-
user: toLoginResult(authResult.getUser(), authResult.getAdditionalUserInfo())
1074+
user: loginResult)
10741075
});
1076+
resolve(loginResult);
10751077
// TODO for reauth and linking, see https://firebase.google.com/docs/auth/android/apple#reauthentication_and_account_linking
10761078
}
10771079
});

0 commit comments

Comments
 (0)