Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 618f74e

Browse files
EddyVerbruggeneddyverbruggen
authored andcommitted
#331 CI builds may file if no entitlements file exists
1 parent 9fa6f73 commit 618f74e

File tree

3 files changed

+25
-10
lines changed

3 files changed

+25
-10
lines changed

CHANGELOG.md

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,27 @@
11
<img src="docs/images/firebase-logo.png" width="116px" height="32px" alt="Firebase"/>
22

33

4+
## 3.11.1 (2017, March 23)
5+
6+
[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.11.0...3.11.1)
7+
8+
### SDK versions
9+
10+
- iOS: 3.13.x
11+
- Android: 10.2.x
12+
13+
### Fixes
14+
- [#331](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/331) CI builds may file if no entitlements file exists
15+
16+
17+
18+
419
## 3.11.0 (2017, March 22)
520

621
[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.10.2...3.11.0)
722

823
### SDK versions
924

10-
If version numbers __changed__, clean your platform folders to avoid build errors.
11-
Also, for Android update your Google Repository in the Android SDK manager (type `android` on the command prompt),
12-
and for iOS do a `pod repo update` to fetch the latest versions from Cocoapods.
13-
1425
- iOS: 3.13.x
1526
- Android: 10.2.x
1627

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nativescript-plugin-firebase",
3-
"version": "3.11.0",
3+
"version": "3.11.1",
44
"description": "Fire. Base. Firebase!",
55
"main": "firebase",
66
"typings": "index.d.ts",

scripts/entitlements-after-prepare.js

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,16 @@ module.exports = function (logger, platformsData, projectData, hookArgs) {
1111
return new Promise(function (resolve, reject) {
1212
if (platform == 'ios') {
1313
fs.exists(entitlementsFile, function (exists) {
14-
if (!exists) return reject(); //Error("entitlementsFile: `" + entitlementsFile + "` not found"));
15-
var dest = path.join(project, projectData.projectName + ".entitlements");
16-
fs.copy(entitlementsFile, dest, function (error) {
17-
if (error) return reject(error);
14+
if (!exists) {
15+
// no need to make noise, this is a totally valid case
1816
resolve();
19-
});
17+
} else {
18+
var dest = path.join(project, projectData.projectName + ".entitlements");
19+
fs.copy(entitlementsFile, dest, function (error) {
20+
if (error) return reject(error);
21+
resolve();
22+
});
23+
}
2024
})
2125
} else {
2226
resolve();

0 commit comments

Comments
 (0)