Validation for analytics event key seems incorrect #1378

EddyVerbruggen · EddyVerbruggen · commit 69150a68fdf8 · 2019-08-27T11:50:36.000+02:00
diff --git a/src/analytics/analytics-common.ts b/src/analytics/analytics-common.ts
@@ -9,7 +9,7 @@ export function validateAnalyticsKey(key: string): string | undefined {
     return "Argument 'key' must be 40 characters or fewer";
   }
 
-  if (!key.match(/^[a-zA-Z][a-zA-Z_]+$/)) {
+  if (!key.match(/^[a-zA-Z0-9][a-zA-Z0-9_]+$/)) {
     return "Argument 'key' can only contain alphanumeric characters and underscores and must start with an alphanumeric character";
   }
 
@@ -67,7 +67,7 @@ function validateAnalyticsParamKey(key: string): string | undefined {
     return "Param 'key' must be 40 characters or fewer";
   }
 
-  if (!key.match(/^[a-zA-Z][a-zA-Z_]+$/)) {
+  if (!key.match(/^[a-zA-Z0-9][a-zA-Z0-9_]+$/)) {
     return "Param 'key' can only contain alphanumeric characters and underscores and must start with an alphanumeric character";
   }
 

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ export function validateAnalyticsKey(key: string): string \| undefined {`
`9`	`9`	`return "Argument 'key' must be 40 characters or fewer";`
`10`	`10`	`}`
`11`	`11`
`12`		`- if (!key.match(/^[a-zA-Z][a-zA-Z_]+$/)) {`
	`12`	`+ if (!key.match(/^[a-zA-Z0-9][a-zA-Z0-9_]+$/)) {`
`13`	`13`	`return "Argument 'key' can only contain alphanumeric characters and underscores and must start with an alphanumeric character";`
`14`	`14`	`}`
`15`	`15`
`@@ -67,7 +67,7 @@ function validateAnalyticsParamKey(key: string): string \| undefined {`
`67`	`67`	`return "Param 'key' must be 40 characters or fewer";`
`68`	`68`	`}`
`69`	`69`
`70`		`- if (!key.match(/^[a-zA-Z][a-zA-Z_]+$/)) {`
	`70`	`+ if (!key.match(/^[a-zA-Z0-9][a-zA-Z0-9_]+$/)) {`
`71`	`71`	`return "Param 'key' can only contain alphanumeric characters and underscores and must start with an alphanumeric character";`
`72`	`72`	`}`
`73`	`73`