Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 6b3ae8b

Browse files
Android build fails because it suddenly can't find com.google.gms:google-services:4.2.0 #1072
1 parent 75ad999 commit 6b3ae8b

File tree

3 files changed

+20
-2
lines changed

3 files changed

+20
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33
- [Firebase iOS SDK Changelog](https://firebase.google.com/support/release-notes/ios)
44
- [Firebase Android SDK Changelog](https://firebase.google.com/support/release-notes/android)
55

6+
## 7.4.5 (2018, December 10)
7+
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/86?closed=1)
8+
9+
610
## 7.4.4 (2018, December 8)
711
[Fixes & Enhancements](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/milestone/85?closed=1)
812

publish/scripts/installer.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1002,7 +1002,7 @@ module.exports = function($logger, $projectData) {
10021002
let repositoriesNode = buildGradleContent.indexOf("repositories", 0);
10031003
if (repositoriesNode > -1) {
10041004
repositoriesNode = buildGradleContent.indexOf("}", repositoriesNode);
1005-
buildGradleContent = buildGradleContent.substr(0, repositoriesNode - 1) + ' maven { url "https://maven.fabric.io/public" }\\n' + buildGradleContent.substr(repositoriesNode - 1);
1005+
buildGradleContent = buildGradleContent.substr(0, repositoriesNode - 1) + '\\t\\tmaven { url "https://maven.fabric.io/public" }\\n\\t\\tmaven { url "https://dl.bintray.com/android/android-tools" }\\n' + buildGradleContent.substr(repositoriesNode - 1);
10061006
}
10071007
10081008
let dependenciesNode = buildGradleContent.indexOf("dependencies", 0);
@@ -1011,6 +1011,13 @@ module.exports = function($logger, $projectData) {
10111011
// see https://docs.fabric.io/android/changelog.html
10121012
buildGradleContent = buildGradleContent.substr(0, dependenciesNode - 1) + ' classpath "io.fabric.tools:gradle:1.26.1"\\n' + buildGradleContent.substr(dependenciesNode - 1);
10131013
}
1014+
1015+
} else if (buildGradleContent.indexOf("https://dl.bintray.com/android/android-tools") === -1) {
1016+
let repositoriesNode = buildGradleContent.indexOf("repositories", 0);
1017+
if (repositoriesNode > -1) {
1018+
repositoriesNode = buildGradleContent.indexOf("}", repositoriesNode);
1019+
buildGradleContent = buildGradleContent.substr(0, repositoriesNode - 1) + '\\t\\tmaven { url "https://dl.bintray.com/android/android-tools" }\\n' + buildGradleContent.substr(repositoriesNode - 1);
1020+
}
10141021
}
10151022
10161023
let gradlePattern = /classpath ('|")com\\.android\\.tools\\.build:gradle:\\d+\\.\\d+\\.\\d+('|")/;

src/scripts/postinstall.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3800,7 +3800,7 @@ module.exports = function($logger, $projectData) {
38003800
let repositoriesNode = buildGradleContent.indexOf("repositories", 0);
38013801
if (repositoriesNode > -1) {
38023802
repositoriesNode = buildGradleContent.indexOf("}", repositoriesNode);
3803-
buildGradleContent = buildGradleContent.substr(0, repositoriesNode - 1) + ' maven { url "https://maven.fabric.io/public" }\\n' + buildGradleContent.substr(repositoriesNode - 1);
3803+
buildGradleContent = buildGradleContent.substr(0, repositoriesNode - 1) + '\\t\\tmaven { url "https://maven.fabric.io/public" }\\n\\t\\tmaven { url "https://dl.bintray.com/android/android-tools" }\\n' + buildGradleContent.substr(repositoriesNode - 1);
38043804
}
38053805
38063806
let dependenciesNode = buildGradleContent.indexOf("dependencies", 0);
@@ -3809,6 +3809,13 @@ module.exports = function($logger, $projectData) {
38093809
// see https://docs.fabric.io/android/changelog.html
38103810
buildGradleContent = buildGradleContent.substr(0, dependenciesNode - 1) + ' classpath "io.fabric.tools:gradle:1.26.1"\\n' + buildGradleContent.substr(dependenciesNode - 1);
38113811
}
3812+
3813+
} else if (buildGradleContent.indexOf("https://dl.bintray.com/android/android-tools") === -1) {
3814+
let repositoriesNode = buildGradleContent.indexOf("repositories", 0);
3815+
if (repositoriesNode > -1) {
3816+
repositoriesNode = buildGradleContent.indexOf("}", repositoriesNode);
3817+
buildGradleContent = buildGradleContent.substr(0, repositoriesNode - 1) + '\\t\\tmaven { url "https://dl.bintray.com/android/android-tools" }\\n' + buildGradleContent.substr(repositoriesNode - 1);
3818+
}
38123819
}
38133820
38143821
let gradlePattern = /classpath ('|")com\\.android\\.tools\\.build:gradle:\\d+\\.\\d+\\.\\d+('|")/;

0 commit comments

Comments
 (0)