Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 6d12ac5

Browse files
EddyVerbruggeneddyverbruggen
authored andcommitted
A few minor fixes
1 parent b11da0d commit 6d12ac5

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

firebase.android.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,8 @@ firebase.init = function (arg) {
157157
return;
158158
}
159159

160+
arg = arg || {};
161+
160162
firebase.ServerValue = {
161163
TIMESTAMP: firebase.toJsObject(com.google.firebase.database.ServerValue.TIMESTAMP)
162164
};
@@ -1721,7 +1723,7 @@ firebase.unsubscribeFromTopic = function(topicName){
17211723
reject(ex);
17221724
}
17231725
});
1724-
}
1726+
};
17251727

17261728
/*
17271729
firebase.sendCrashLog = function (arg) {

firebase.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ export interface SendCrashLogOptions {
462462
log: string;
463463
}
464464

465-
export function init(options: InitOptions): Promise<any>;
465+
export function init(options?: InitOptions): Promise<any>;
466466

467467
// Database
468468
export function push(path: string, value: any): Promise<PushResult>;

firebase.ios.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,8 @@ firebase.init = function (arg) {
420420
};
421421

422422
function runInit() {
423+
arg = arg || {};
424+
423425
prepAppDelegate();
424426

425427
// this requires you to download GoogleService-Info.plist and

platforms/ios/build.xcconfig.admob

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
OTHER_LDFLAGS = $(inherited) -framework "QuartzCore" -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_CGSizeFromGADAdSize -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADSimulatorID -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADErrorDomain -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeBanner -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeFluid -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeFullBanner -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeInvalid -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeLargeBanner -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeLeaderboard -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeMediumRectangle -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSkyscraper -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerLandscape -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerPortrait -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerSkinnyLandscape -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerSkinnyPortrait
1+
OTHER_LDFLAGS = $(inherited) -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_CGSizeFromGADAdSize -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADSimulatorID -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADErrorDomain -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeBanner -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeFluid -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeFullBanner -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeInvalid -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeLargeBanner -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeLeaderboard -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeMediumRectangle -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSkyscraper -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerLandscape -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerPortrait -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerSkinnyLandscape -force_load $(PODS_ROOT)/Google-Mobile-Ads-SDK/Frameworks/frameworks/GoogleMobileAds.framework/GoogleMobileAds -Wl,-exported_symbol,_kGADAdSizeSmartBannerSkinnyPortrait

0 commit comments

Comments
 (0)