#74 Added Facebook Login for Android - small tweaks & version bump

Author: EddyVerbruggen

CHANGELOG.md

@@ -1,5 +1,20 @@
 <img src="docs/images/firebase-logo.png" width="116px" height="32px" alt="Firebase"/>
 
+## 3.4.3 (2016, July 16)
+
+[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.4.2...3.4.3)
+
+### SDK versions
+If version numbers changed clean your platform folders to avoid build errors.
+
+- iOS: 3.3.x
+- Android: 9.2.0
+
+### New
+- [#74](#74) Facebook login for Android.
+
+
+
 ## 3.4.2 (2016, July 14)
 
 [Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.4.0...3.4.2)

docs/AUTHENTICATION.md

@@ -203,11 +203,18 @@ Then add the following lines to your code and check for setup instructions for y
 
 #### Android
 
-1. Uncomment the facebook plugin in `node_modules\nativescript-plugin-firebase\platforms\android\include.gradle`
-2. Add `<meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/facebook_app_id"/>` to the manifest/application tag in `app\App_Resources\Android\AndroidManifest.xml`
-3. Add `<string name="facebook_app_id">1234</string>` to `platforms\android\src\main\res\values\strings.xml`
-4. In your facebook dev console, add the Android app and set the Google Play Packagename to your applicationId (see your `package.config` or in `app\App_Resources\Android\app.gradle`) and the Classname to `com.tns.NativeScriptActivity`.
-5. Set the Key-Hash as well. If you don't know it you can also try facebook login in your app and observe the `adb logcat` output for something like `Key hash <......> does not match any stored key hashes.` 
+1. Uncomment the facebook SDK in `node_modules\nativescript-plugin-firebase\platforms\android\include.gradle`
+2. Add `<meta-data android:name="com.facebook.sdk.ApplicationId" android:value="@string/facebook_app_id"/>` to the `manifest/application tag` in `app\App_Resources\Android\AndroidManifest.xml`
+3. Create a file `app\App_Resources\Android\facebooklogin.xml` and add this (replace the id):
+
+   ```xml
+   <?xml version='1.0' encoding='utf-8'?>
+   <resources>
+     <string name="facebook_app_id">126035687816994</string>
+   </resources>
+   ```
+4. In your Facebook dev console, go to the Basic settings and add the Android platform if you haven't already. Then set the 'Google Play Packagename' to your applicationId (see your `package.json`) and set 'Classname' to `com.tns.NativeScriptActivity`.
+5. Set the Key-Hash as well. If you don't know it you can try Facebook login in your app and observe the `adb logcat` output for something like `Key hash <......> does not match any stored key hashes.` 
 
 ### logout
 Shouldn't be more complicated than:

firebase.android.js

@@ -188,17 +188,16 @@ firebase.init = function (arg) {
         firebase.storage = com.google.firebase.storage.FirebaseStorage.getInstance().getReferenceFromUrl(arg.storageBucket);
       }
 
+      // Facebook
       if (typeof(com.facebook) !== "undefined") {
         com.facebook.FacebookSdk.sdkInitialize(appModule.android.context);
         fbCallbackManager = com.facebook.CallbackManager.Factory.create();
         appModule.android.on("activityResult",function(eventData){
           fbCallbackManager.onActivityResult(eventData.requestCode, eventData.resultCode, eventData.intent);
-        })
+        });
       }
 
-
-
-        resolve(firebase.instance);
+      resolve(firebase.instance);
     } catch (ex) {
       console.log("Error in firebase.init: " + ex);
       reject(ex);