Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 93ffada

Browse files
[iOS] New Version in NPM has podfile error during build #684
1 parent b614591 commit 93ffada

File tree

3 files changed

+17
-14
lines changed

3 files changed

+17
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
## 5.3.1 (2018, April 26)
88

99
### Fixes
10+
- [#684](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/684) [iOS] New Version in NPM has podfile error during build
1011
- [#685](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/685) error TS1036: Statements are not allowed in ambient contexts
1112

1213

publish/scripts/installer.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -246,14 +246,15 @@ pod 'Firebase/Auth'
246246
# Uncomment if you want to enable Crashlytics
247247
` + (isSelected(result.crashlytics) ? `` : `#`) + `pod 'Fabric'
248248
` + (isSelected(result.crashlytics) ? `` : `#`) + `pod 'Crashlytics'
249+
` + (!isSelected(result.crashlytics) ? `` : `
249250
# Crashlytics works best without bitcode
250-
` + (isSelected(result.crashlytics) ? `` : `#`) + `post_install do |installer|
251-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` installer.pods_project.targets.each do |target|
252-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` target.build_configurations.each do |config|
253-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` config.build_settings['ENABLE_BITCODE'] = "NO"
254-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` end
255-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` end
256-
` + (isSelected(result.crashlytics) ? `` : `#`) + `end
251+
post_install do |installer|
252+
installer.pods_project.targets.each do |target|
253+
target.build_configurations.each do |config|
254+
config.build_settings['ENABLE_BITCODE'] = "NO"
255+
end
256+
end
257+
end`) + `
257258
258259
# Uncomment if you want to enable FCM (Firebase Cloud Messaging)
259260
` + (isSelected(result.messaging) ? `` : `#`) + `pod 'Firebase/Messaging'

src/scripts/postinstall.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3044,14 +3044,15 @@ pod 'Firebase/Auth'
30443044
# Uncomment if you want to enable Crashlytics
30453045
` + (isSelected(result.crashlytics) ? `` : `#`) + `pod 'Fabric'
30463046
` + (isSelected(result.crashlytics) ? `` : `#`) + `pod 'Crashlytics'
3047+
` + (!isSelected(result.crashlytics) ? `` : `
30473048
# Crashlytics works best without bitcode
3048-
` + (isSelected(result.crashlytics) ? `` : `#`) + `post_install do |installer|
3049-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` installer.pods_project.targets.each do |target|
3050-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` target.build_configurations.each do |config|
3051-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` config.build_settings['ENABLE_BITCODE'] = "NO"
3052-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` end
3053-
` + (isSelected(result.crashlytics) ? `` : `#`) + ` end
3054-
` + (isSelected(result.crashlytics) ? `` : `#`) + `end
3049+
post_install do |installer|
3050+
installer.pods_project.targets.each do |target|
3051+
target.build_configurations.each do |config|
3052+
config.build_settings['ENABLE_BITCODE'] = "NO"
3053+
end
3054+
end
3055+
end`) + `
30553056
30563057
# Uncomment if you want to enable FCM (Firebase Cloud Messaging)
30573058
` + (isSelected(result.messaging) ? `` : `#`) + `pod 'Firebase/Messaging'

0 commit comments

Comments
 (0)