Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 943b852

Browse files
Xcode 8 compatibility #135
1 parent 3617c33 commit 943b852

File tree

4 files changed

+23
-5
lines changed

4 files changed

+23
-5
lines changed

CHANGELOG.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,20 @@
11
<img src="docs/images/firebase-logo.png" width="116px" height="32px" alt="Firebase"/>
22

3+
## 3.6.3 (2016, September 21)
4+
5+
[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.6.2...3.6.3)
6+
7+
### SDK versions
8+
If version numbers __changed__, clean your platform folders to avoid build errors.
9+
10+
- iOS: 3.5.x
11+
- Android: 9.4.0
12+
13+
### Fixes
14+
- [#135](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/issues/135) Xcode 8 compatibility (iOS 10 SDK)
15+
16+
17+
318
## 3.6.2 (2016, September 15)
419

520
[Full changelog](https://github.com/EddyVerbruggen/nativescript-plugin-firebase/compare/3.6.1...3.6.2)

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
<img src="docs/images/firebase-logo.png" width="116px" height="32px" alt="Firebase"/><br/>
44
Google's realtime app platform (Database, Authentication, Configuration, Notifications) [firebase.google.com](https://firebase.google.com/)
55

6+
> Requires NativeScript 2.3.0 or up. So `npm install -g nativescript` like a boss if you need to!
7+
68
## Features
79
For readability the supported features have been moved to their own README's:
810

firebase.ios.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
var firebase = require("./firebase-common");
2-
var fs = require("file-system");
32
var application = require("application");
3+
var utils = require("utils/utils");
44
var types = require("utils/types");
55
var frame = require("ui/frame");
66

@@ -9,7 +9,8 @@ firebase._pendingNotifications = [];
99
firebase._receivedPushTokenCallback = null;
1010

1111
firebase._addObserver = function (eventName, callback) {
12-
return NSNotificationCenter.defaultCenter().addObserverForNameObjectQueueUsingBlock(eventName, null, NSOperationQueue.mainQueue(), callback);
12+
var queue = utils.ios.getter(NSOperationQueue, NSOperationQueue.mainQueue);
13+
return utils.ios.getter(NSNotificationCenter, NSNotificationCenter.defaultCenter).addObserverForNameObjectQueueUsingBlock(eventName, null, queue, callback);
1314
};
1415

1516
firebase.addAppDelegateMethods = function(appDelegate) {
@@ -145,7 +146,7 @@ firebase._processPendingNotifications = function() {
145146
firebase._receivedNotificationCallback(userInfoJSON);
146147
}
147148
firebase._pendingNotifications = [];
148-
UIApplication.sharedApplication().applicationIconBadgeNumber = 0;
149+
utils.ios.getter(UIApplication, UIApplication.sharedApplication).applicationIconBadgeNumber = 0;
149150
}
150151
};
151152

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"main" : "firebase.js",
66
"nativescript": {
77
"platforms": {
8-
"android": "1.7.0",
9-
"ios": "1.7.0"
8+
"android": "2.3.0",
9+
"ios": "2.3.0"
1010
}
1111
},
1212
"scripts": {

0 commit comments

Comments
 (0)