Skip to content
This repository was archived by the owner on Apr 4, 2023. It is now read-only.

Commit 96a23d4

Browse files
Merge pull request #1250 from vtrifonov/master
use fully qualified VersionNumber
2 parents 07ca73a + fb2515b commit 96a23d4

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

publish/scripts/installer.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -515,10 +515,10 @@ const string3 = \`
515515
// Per https://docs.fabric.io/apple/crashlytics/enhanced-reports.html#custom-logs :
516516
// Crashlytics ensures that all log entries are recorded, even if the very next line of code crashes.
517517
// This means that logging must incur some IO. Be careful when logging in performance-critical areas.
518-
518+
519519
// As per the note above, enabling this can affect performance if too much logging is present.
520520
// stdout->_write = stdout_redirect;
521-
521+
522522
// stderr usually only occurs during critical failures;
523523
// so it is usually essential to identifying crashes, especially in JS
524524
stderr->_write = stderr_redirect;
@@ -728,8 +728,8 @@ repositories {
728728
dependencies {
729729
def supportVersion = project.hasProperty("supportVersion") ? project.supportVersion : "26.1.0"
730730
def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : "16.0.1"
731-
732-
if (googlePlayServicesVersion != '+' && VersionNumber.parse(googlePlayServicesVersion) < VersionNumber.parse('15.0.+')) {
731+
732+
if (googlePlayServicesVersion != '+' && org.gradle.util.VersionNumber.parse(googlePlayServicesVersion) < org.gradle.util.VersionNumber.parse('15.0.+')) {
733733
throw new GradleException(" googlePlayServicesVersion set too low, please update to at least 15.0.0 / 15.0.+ (currently set to $googlePlayServicesVersion)");
734734
}
735735

src/scripts/postinstall.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2251,7 +2251,7 @@ function coerce(version) {
22512251
if (match == null)
22522252
return null;
22532253

2254-
return parse((match[1] || '0') + '.' + (match[2] || '0') + '.' + (match[3] || '0'));
2254+
return parse((match[1] || '0') + '.' + (match[2] || '0') + '.' + (match[3] || '0'));
22552255
}
22562256

22572257

@@ -4687,10 +4687,10 @@ const string3 = \`
46874687
// Per https://docs.fabric.io/apple/crashlytics/enhanced-reports.html#custom-logs :
46884688
// Crashlytics ensures that all log entries are recorded, even if the very next line of code crashes.
46894689
// This means that logging must incur some IO. Be careful when logging in performance-critical areas.
4690-
4690+
46914691
// As per the note above, enabling this can affect performance if too much logging is present.
46924692
// stdout->_write = stdout_redirect;
4693-
4693+
46944694
// stderr usually only occurs during critical failures;
46954695
// so it is usually essential to identifying crashes, especially in JS
46964696
stderr->_write = stderr_redirect;
@@ -4900,8 +4900,8 @@ repositories {
49004900
dependencies {
49014901
def supportVersion = project.hasProperty("supportVersion") ? project.supportVersion : "26.1.0"
49024902
def googlePlayServicesVersion = project.hasProperty('googlePlayServicesVersion') ? project.googlePlayServicesVersion : "16.0.1"
4903-
4904-
if (googlePlayServicesVersion != '+' && VersionNumber.parse(googlePlayServicesVersion) < VersionNumber.parse('15.0.+')) {
4903+
4904+
if (googlePlayServicesVersion != '+' && org.gradle.util.VersionNumber.parse(googlePlayServicesVersion) < org.gradle.util.VersionNumber.parse('15.0.+')) {
49054905
throw new GradleException(" googlePlayServicesVersion set too low, please update to at least 15.0.0 / 15.0.+ (currently set to $googlePlayServicesVersion)");
49064906
}
49074907

0 commit comments

Comments
 (0)